virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	xen-devel@lists.xensource.com,
	virtualization@lists.linux-foundation.org,
	Randy Dunlap <rdunlap@xenotime.net>, Ingo Molnar <mingo@elte.hu>
Subject: Re: xen: how does XEN_PRIVILEGED_GUEST work?
Date: Sat, 23 Mar 2013 09:22:11 -0400	[thread overview]
Message-ID: <20130323132211.GA8676@phenom.dumpdata.com> (raw)
In-Reply-To: <1363991855.1390.213.camel@x61.thuisdomein>

On Fri, Mar 22, 2013 at 11:37:35PM +0100, Paul Bolle wrote:
> 0) The Kconfig symbol XEN_PRIVILEGED_GUEST got added to the mainline
> Linux repository in v2.6.37. It has never been used. It has always been
> a nop.
> 
> 1) Its Kconfig entry is preceded with this comment:
>     # Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
>     # name in tools.
> 
> What does that mean?

[root@phenom minutes]# cat /etc/grub.d/20_linux_xen |grep PRIV
        if (grep -qx "CONFIG_XEN_DOM0=y" "${config}" 2> /dev/null || grep -qx "CONFIG_XEN_PRIVILEGED_GUEST=y" "${config}" 2> /dev/null); then echo -n "$i " ; fi

> 
> 2) On a related note: can anyone please explain commit
> 7c1bfd685bcdc822ab1d7411ea05c82bd2a7b260 ("xen/pci: Fix compiler error
> when CONFIG_XEN_PRIVILEGED_GUEST is not set.") and commit

Hm, the change actually was for CONFIG_XEN_DOM0. Title is incorrect

> c00c8aa2d976e9ed1d12a57b42d6e9b27efb7abe ("xen/trace: Fix compile error
> when CONFIG_XEN_PRIVILEGED_GUEST is not set"). Do they perhaps fix
> problems in code not mainlined?

No. That one was triggered by some juicy random config that Randy's
randconfig found.

> 
> 
> Paul Bolle
> 

  reply	other threads:[~2013-03-23 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 22:37 xen: how does XEN_PRIVILEGED_GUEST work? Paul Bolle
2013-03-23 13:22 ` Konrad Rzeszutek Wilk [this message]
2013-03-23 13:59   ` Paul Bolle
2013-03-25 13:45     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130323132211.GA8676@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=jeremy@goop.org \
    --cc=mingo@elte.hu \
    --cc=pebolle@tiscali.nl \
    --cc=randy.dunlap@oracle.com \
    --cc=rdunlap@xenotime.net \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).