virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: xen-devel@lists.xensource.com,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Ingo Molnar <mingo@elte.hu>, Randy Dunlap <rdunlap@xenotime.net>,
	virtualization@lists.linux-foundation.org
Subject: Re: xen: how does XEN_PRIVILEGED_GUEST work?
Date: Mon, 25 Mar 2013 09:45:11 -0400	[thread overview]
Message-ID: <20130325134511.GB11546@phenom.dumpdata.com> (raw)
In-Reply-To: <1364047175.1390.249.camel@x61.thuisdomein>

On Sat, Mar 23, 2013 at 02:59:35PM +0100, Paul Bolle wrote:
> On Sat, 2013-03-23 at 09:22 -0400, Konrad Rzeszutek Wilk wrote:
> > On Fri, Mar 22, 2013 at 11:37:35PM +0100, Paul Bolle wrote:
> > > 1) Its Kconfig entry is preceded with this comment:
> > >     # Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
> > >     # name in tools.
> > > 
> > > What does that mean?
> > 
> > [root@phenom minutes]# cat /etc/grub.d/20_linux_xen |grep PRIV
> >         if (grep -qx "CONFIG_XEN_DOM0=y" "${config}" 2> /dev/null || grep -qx "CONFIG_XEN_PRIVILEGED_GUEST=y" "${config}" 2> /dev/null); then echo -n "$i " ; fi
> 
> Thanks.
> 
> Can userspace require the build system to keep using some Kconfig symbol
> by doing tests like these? Anyhow, if that's the only tool then

I don't know if there are rules written down for this sort of thing - but
I presume there are some utilities that check the /proc/config.gz to
see if certain options are enabled? This is not that much different from that.

> XEN_PRIVILEGED_GUEST can be dropped. XEN_PRIVILIGED_GUEST should always
> be equal to XEN_DOM0 so this if () test will evaluate identically with
> the sub-test for CONFIG_XEN_PRIVILIGED_GUEST removed.

That is the only tool that I am aware of.

But if we wanted to drop one of those CONFIG_ options I would be more happy
with dropping of the XEN_DOM0. As the initial domain is not that different
from any PV domain - except that it can do ACPI, VGA, and some EFI stuff.
In essence it is a priviliged guest type.

It might make more sense to have the XEN_PRIVILIGED_GUEST be the option
that that would define whether there should be a dependency on the ACPI, VGA, etc
stuff.

Unfortunatly the XEN_DOM0 seems to be so interleaved in the header/source code
that this would take some surgery to get right.

> 
> 
> Paul Bolle
> 

      reply	other threads:[~2013-03-25 13:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 22:37 xen: how does XEN_PRIVILEGED_GUEST work? Paul Bolle
2013-03-23 13:22 ` Konrad Rzeszutek Wilk
2013-03-23 13:59   ` Paul Bolle
2013-03-25 13:45     ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130325134511.GB11546@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=jeremy@goop.org \
    --cc=mingo@elte.hu \
    --cc=pebolle@tiscali.nl \
    --cc=rdunlap@xenotime.net \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).