From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 0/2] virtio-spec: dynamic network offloads configuration Date: Wed, 27 Mar 2013 17:27:50 +0200 Message-ID: <20130327152750.GC29249@redhat.com> References: <1364391798-8058-1-git-send-email-dmitry@daynix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1364391798-8058-1-git-send-email-dmitry@daynix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Dmitry Fleytman Cc: Yan Vugenfirer , Dmitry Fleytman , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Wed, Mar 27, 2013 at 03:43:16PM +0200, Dmitry Fleytman wrote: > From: Dmitry Fleytman > > One of recently introduced Windows features (RSC) > requires network driver to be able to enable and disable > HW LRO offload on the fly without device reinitialization. > > Current Virtio specification doesn't support this requirement. > The solution proposed by following spec patch is to add > a new control command for this purpose. > > The same solution may be used in Linux driver for ethtool interface > implementation. > > Patch for QEMU mainline that implements this specification change > attached as well for reference. A minor note: sticking _GUEST_ in the command name might be a good idea. Sents some more minor comments per-patch. > Dmitry Fleytman (1): > virtio-net: dynamic network offloads configuration > > hw/virtio-net.c | 110 +++++++++++++++++++++++++++++++++++++++++++++++--------- > hw/virtio-net.h | 19 ++++++++++ > 2 files changed, 113 insertions(+), 16 deletions(-) > > -- > 1.8.1.4