From: "Michael S. Tsirkin" <mst@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH V2 2/2] tcm_vhost: Use vq->private_data to indicate if the endpoint is setup
Date: Fri, 12 Apr 2013 14:37:54 +0300 [thread overview]
Message-ID: <20130412113754.GE23467@redhat.com> (raw)
In-Reply-To: <874nfp7tai.fsf@rustcorp.com.au>
On Tue, Apr 02, 2013 at 09:27:57AM +1030, Rusty Russell wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> > Rusty's currently doing some reorgs of -net let's delay
> > cleanups there to avoid stepping on each other's toys.
> > Let's focus on scsi here.
> > E.g. any chance framing assumptions can be fixed in 3.10?
>
> I am waiting for your removal of the dma-compelete ordering stuff in
> vhost-net.
>
> Cheers,
> Rusty.
Now, it looks like it's actually a smart datastructure.
It allows signalling consumptions from multiple
without any locks, with multiple consumers, and just
a single kref counter.
Nothing simpler than a producer/consumer does this.
Yes it can in theory delay some tx completions a bit but
normally no one is waiting for them.
We can refactor it to save some memory, and cleanup
the code, playing with this now.
next prev parent reply other threads:[~2013-04-12 11:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 2:17 [PATCH V2 0/2] tcm_vhost endpoint Asias He
2013-03-28 2:17 ` [PATCH V2 1/2] tcm_vhost: Initialize vq->last_used_idx when set endpoint Asias He
2013-03-28 2:17 ` [PATCH V2 2/2] tcm_vhost: Use vq->private_data to indicate if the endpoint is setup Asias He
[not found] ` <1364437048-19932-2-git-send-email-asias@redhat.com>
2013-03-28 2:54 ` [PATCH V2 1/2] tcm_vhost: Initialize vq->last_used_idx when set endpoint Nicholas A. Bellinger
[not found] ` <1364439247.17698.72.camel@haakon2.linux-iscsi.org>
2013-03-28 3:21 ` Asias He
[not found] ` <1364437048-19932-3-git-send-email-asias@redhat.com>
2013-03-28 6:16 ` [PATCH V2 2/2] tcm_vhost: Use vq->private_data to indicate if the endpoint is setup Michael S. Tsirkin
2013-03-28 8:10 ` Asias He
2013-03-28 8:33 ` Michael S. Tsirkin
[not found] ` <20130328083330.GA17829@redhat.com>
2013-03-28 8:47 ` Asias He
2013-03-28 9:06 ` Michael S. Tsirkin
2013-03-29 6:27 ` Asias He
[not found] ` <20130329062750.GB32106@hj.localdomain>
2013-03-31 8:23 ` Michael S. Tsirkin
[not found] ` <20130331082312.GJ23484@redhat.com>
2013-04-01 2:20 ` Asias He
2013-04-01 22:57 ` Rusty Russell
[not found] ` <874nfp7tai.fsf@rustcorp.com.au>
2013-04-02 13:10 ` Michael S. Tsirkin
2013-04-12 11:37 ` Michael S. Tsirkin [this message]
2013-03-28 9:18 ` Michael S. Tsirkin
[not found] ` <20130328091821.GC18482@redhat.com>
2013-03-29 6:22 ` Asias He
2013-03-31 8:20 ` Michael S. Tsirkin
2013-04-01 2:13 ` Asias He
2013-04-02 12:15 ` Michael S. Tsirkin
2013-04-02 15:10 ` Asias He
2013-04-02 15:18 ` Michael S. Tsirkin
2013-04-03 6:08 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130412113754.GE23467@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).