virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Asias He <asias@redhat.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	target-devel@vger.kernel.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v11 4/4] tcm_vhost: Enable VIRTIO_SCSI_F_HOTPLUG
Date: Thu, 25 Apr 2013 10:40:48 +0300	[thread overview]
Message-ID: <20130425074048.GE7857@redhat.com> (raw)
In-Reply-To: <1366875323-17639-5-git-send-email-asias@redhat.com>

On Thu, Apr 25, 2013 at 03:35:23PM +0800, Asias He wrote:
> Everything for hotplug is ready. Let's enable the feature bit.
> 
> Signed-off-by: Asias He <asias@redhat.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  drivers/vhost/tcm_vhost.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c
> index 07217d8..1677238 100644
> --- a/drivers/vhost/tcm_vhost.c
> +++ b/drivers/vhost/tcm_vhost.c
> @@ -66,7 +66,8 @@ enum {
>   * TODO: debug and remove the workaround.
>   */
>  enum {
> -	VHOST_SCSI_FEATURES = VHOST_FEATURES & (~VIRTIO_RING_F_EVENT_IDX)
> +	VHOST_SCSI_FEATURES = (VHOST_FEATURES & (~VIRTIO_RING_F_EVENT_IDX)) |
> +			      (1ULL << VIRTIO_SCSI_F_HOTPLUG)
>  };
>  
>  #define VHOST_SCSI_MAX_TARGET	256
> -- 
> 1.8.1.4

  parent reply	other threads:[~2013-04-25  7:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25  7:35 [PATCH v11 0/4] tcm_vhost hotplug Asias He
2013-04-25  7:35 ` [PATCH v11 1/4] tcm_vhost: Refactor the lock nesting rule Asias He
2013-04-25  7:39   ` Michael S. Tsirkin
2013-04-25  7:35 ` [PATCH v11 2/4] tcm_vhost: Add hotplug/hotunplug support Asias He
2013-04-25  7:35 ` [PATCH v11 3/4] tcm_vhost: Add ioctl to get and set events missed flag Asias He
2013-04-25  7:40   ` Michael S. Tsirkin
2013-04-25  7:35 ` [PATCH v11 4/4] tcm_vhost: Enable VIRTIO_SCSI_F_HOTPLUG Asias He
2013-04-25  7:39 ` [PATCH v11 0/4] tcm_vhost hotplug Michael S. Tsirkin
2013-04-25  8:19   ` Nicholas A. Bellinger
     [not found] ` <1366875323-17639-3-git-send-email-asias@redhat.com>
2013-04-25  7:40   ` [PATCH v11 2/4] tcm_vhost: Add hotplug/hotunplug support Michael S. Tsirkin
     [not found] ` <1366875323-17639-5-git-send-email-asias@redhat.com>
2013-04-25  7:40   ` Michael S. Tsirkin [this message]
2013-04-25  9:32   ` [PATCH untested] vhost: allow device specific fields per vq Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130425074048.GE7857@redhat.com \
    --to=mst@redhat.com \
    --cc=asias@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).