From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
xen-devel@lists.xensource.com, kernel-janitors@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [patch -resend] xen/privcmd: fix condition in privcmd_close()
Date: Wed, 15 May 2013 10:23:22 -0400 [thread overview]
Message-ID: <20130515142322.GK15529@phenom.dumpdata.com> (raw)
In-Reply-To: <20130515065624.GA20381@elgon.mountain>
On Wed, May 15, 2013 at 09:56:24AM +0300, Dan Carpenter wrote:
> The parenthesis are in the wrong place so the original code is
> equivalent to:
>
> if (!xen_feature(0x1)) { ...
> Or:
> if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ...
>
> Which obviously was not intended.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I sent this last November but it was never merged.
Ah, it was, but in a different branch (stable/pvh.v8). Let me stick it on branch for Linus.
prev parent reply other threads:[~2013-05-15 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 6:42 [patch] xen/privcmd: fix condition in privcmd_close() Dan Carpenter
2013-05-15 6:56 ` [patch -resend] " Dan Carpenter
2013-05-15 14:23 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515142322.GK15529@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=jeremy@goop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).