* [PATCH] virtio_console: fix uapi header
@ 2013-05-16 16:44 Michael S. Tsirkin
2013-05-17 1:16 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2013-05-16 16:44 UTC (permalink / raw)
To: kvm
Cc: Michael S. Tsirkin, linux-kernel, virtualization, David Howells,
Michael Kerrisk, Amit Shah, Thomas Gleixner, Paul E. McKenney
uapi should use __u32 not u32.
Fix a macro in virtio_console.h which uses u32.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/uapi/linux/virtio_console.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/virtio_console.h b/include/uapi/linux/virtio_console.h
index ee13ab6..c312f16 100644
--- a/include/uapi/linux/virtio_console.h
+++ b/include/uapi/linux/virtio_console.h
@@ -39,7 +39,7 @@
#define VIRTIO_CONSOLE_F_SIZE 0 /* Does host provide console size? */
#define VIRTIO_CONSOLE_F_MULTIPORT 1 /* Does host provide multiple ports? */
-#define VIRTIO_CONSOLE_BAD_ID (~(u32)0)
+#define VIRTIO_CONSOLE_BAD_ID (~(__u32)0)
struct virtio_console_config {
/* colums of the screens */
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_console: fix uapi header
2013-05-16 16:44 [PATCH] virtio_console: fix uapi header Michael S. Tsirkin
@ 2013-05-17 1:16 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2013-05-17 1:16 UTC (permalink / raw)
To: kvm
Cc: Michael S. Tsirkin, linux-kernel, virtualization, David Howells,
Michael Kerrisk, Amit Shah, Thomas Gleixner, Paul E. McKenney
"Michael S. Tsirkin" <mst@redhat.com> writes:
> uapi should use __u32 not u32.
> Fix a macro in virtio_console.h which uses u32.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Ouch. Added CC:stable, and put into fixes. Mainly because it's
embarrassing :)
Cheers,
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-17 1:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-16 16:44 [PATCH] virtio_console: fix uapi header Michael S. Tsirkin
2013-05-17 1:16 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).