From: Amit Shah <amit.shah@redhat.com>
To: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
yrl.pp-manager.tt@hitachi.com,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Subject: Re: [PATCH V2 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write
Date: Fri, 19 Jul 2013 15:35:43 +0530 [thread overview]
Message-ID: <20130719100543.GM3087@amit-x200.redhat.com> (raw)
In-Reply-To: <20130719091951.9698.95194.stgit@yunodevel>
On (Fri) 19 Jul 2013 [18:19:51], Yoshihiro YUNOMAE wrote:
> Hi,
>
> This patch set fixes two bugs of splice_write in the virtio-console driver.
>
> [BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write.
> => This induces oops in sg_init_table().
>
> [BUG2] No lock for competition of splice_write.
> => This induces oops in splice_from_pipe_feed() by bug of any user
> application.
>
> These reports are written in each patch.
>
> Changes in V2:
> - Fix a locking problem for error
>
> Thanks!
Reviewed-by: Amit Shah <amit.shah@redhat.com>
For the patches to be picked up in the stable trees, you need to
include CC: <stable@vger.kernel.org> in the sign-off area of the
patches, just cc'ing in the patch posting doesn't help. See
Documentation/stable_kernel_rules.txt.
Can you submit a v3 with that change, and also add my reviewed-by
line?
Amit
next prev parent reply other threads:[~2013-07-19 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:19 [PATCH V2 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write Yoshihiro YUNOMAE
2013-07-19 9:19 ` [PATCH V2 1/2] [BUGFIX] virtio/console: Quit from splice_write if pipe->nrbufs is 0 Yoshihiro YUNOMAE
2013-07-19 12:25 ` Masami Hiramatsu
2013-07-19 9:19 ` [PATCH V2 2/2] [BUGFIX] virtio/console: Add pipe_lock/unlock for splice_write Yoshihiro YUNOMAE
2013-07-19 10:05 ` Amit Shah [this message]
2013-07-22 1:05 ` Re: [PATCH V2 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write Yoshihiro YUNOMAE
[not found] ` <20130719091956.9698.30207.stgit@yunodevel>
2013-07-19 12:26 ` [PATCH V2 2/2] [BUGFIX] virtio/console: Add pipe_lock/unlock for splice_write Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719100543.GM3087@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yoshihiro.yunomae.ez@hitachi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).