From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] virtio: console: fix error handling for debugfs_create_dir() Date: Mon, 22 Jul 2013 01:33:54 +0300 Message-ID: <20130721223354.GH5585@mwanda> References: <20130719055049.GD9729@elgon.mountain> <201307191228.41794.arnd@arndb.de> <20130720215048.GD5636@mwanda> <201307211136.25989.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201307211136.25989.arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Arnd Bergmann Cc: Amit Shah , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org > I don't see where that oops would happen. In the code I'm looking at, > all uses of ->debugfs_dir only ever get passed into other debugfs > functions that are stubbed out to empty inline functions. > > It's not the most obvious interface design, but this all seems intentional > and correct to me. Ah. Ok. You're right. regards, dan carpenter