From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 9/9] virtio: console: prevent use-after-free of port name in port unplug
Date: Fri, 2 Aug 2013 14:09:21 +0530 [thread overview]
Message-ID: <20130802083921.GC28594@grmbl.mre> (raw)
In-Reply-To: <87ob9i445k.fsf@rustcorp.com.au>
On (Thu) 01 Aug 2013 [10:29:35], Rusty Russell wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> > On (Mon) 29 Jul 2013 [14:26:09], Rusty Russell wrote:
> >> Amit Shah <amit.shah@redhat.com> writes:
> >> > Remove the debugfs path before freeing port->name, to prevent a possible
> >> > use-after-free.
> >> >
> >> > Reported-by: Jason Wang <jasowang@redhat.com>
> >> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> >>
> >> Applied,
> >> Rusty.
> >
> > Hey Rusty, I don't see this patch in your virtio-next branch:
> >
> > https://git.kernel.org/cgit/linux/kernel/git/rusty/linux.git/log/?h=virtio-next
> >
> > The others are present there. Looks like this one got missed?
>
> Actually, it's in my pending-rebases branch, since it requireds things
> from the fixes branch. Once the fixes branch has gone to Linus (this
> week) I will merge it into the virtio-next branch then apply this on
> top.
Ah, thanks!
> It's generally considered bad form to merge into -next branches, but
> it's allowed for cases like this. But I want to make sure no changes to
> fixes are required before I merge it, hence the delay for some exposure
> in linux-next.
Got it, thanks for the explanation!
Amit
next prev parent reply other threads:[~2013-08-02 8:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 13:58 [PATCH v3 0/9] virtio: console: fixes for bugs and races with unplug Amit Shah
2013-07-25 13:58 ` [PATCH v3 1/9] virtio: console: fix race with port unplug and open/close Amit Shah
2013-07-25 13:58 ` [PATCH v3 2/9] virtio: console: fix race in port_fops_open() and port unplug Amit Shah
2013-07-25 13:58 ` [PATCH v3 3/9] virtio: console: clean up port data immediately at time of unplug Amit Shah
2013-07-25 13:58 ` [PATCH v3 4/9] virtio: console: fix raising SIGIO after port unplug Amit Shah
2013-07-25 13:58 ` [PATCH v3 5/9] virtio: console: return -ENODEV on all read operations after unplug Amit Shah
2013-07-25 13:58 ` [PATCH v3 6/9] virtio: console: add locks around buffer removal in port unplug path Amit Shah
2013-07-29 4:53 ` Rusty Russell
2013-07-25 13:58 ` [PATCH v3 7/9] virtio: console: add locking " Amit Shah
2013-07-29 4:54 ` Rusty Russell
2013-07-25 13:58 ` [PATCH v3 8/9] virtio: console: fix locking around send_sigio_to_port() Amit Shah
2013-07-29 4:55 ` Rusty Russell
2013-07-25 13:58 ` [PATCH v3 9/9] virtio: console: prevent use-after-free of port name in port unplug Amit Shah
2013-07-29 4:56 ` Rusty Russell
2013-07-31 8:10 ` Amit Shah
2013-08-01 0:59 ` Rusty Russell
2013-08-02 8:39 ` Amit Shah [this message]
[not found] ` <7ca111ad3bca069f921b4234e5b3ccbbfd7a11d8.1374759439.git.amit.shah@redhat.com>
2013-07-29 4:48 ` [PATCH v3 1/9] virtio: console: fix race with port unplug and open/close Rusty Russell
[not found] ` <87ob9m6kej.fsf@rustcorp.com.au>
2013-07-30 9:28 ` Amit Shah
[not found] ` <d8ffeceebfc527db85406850d22fa3da64aabbe3.1374759439.git.amit.shah@redhat.com>
2013-07-29 4:50 ` [PATCH v3 3/9] virtio: console: clean up port data immediately at time of unplug Rusty Russell
[not found] ` <a3aca79feb7163e08b940ddefceabf78ab4cd8ce.1374759439.git.amit.shah@redhat.com>
2013-07-29 4:50 ` [PATCH v3 2/9] virtio: console: fix race in port_fops_open() and port unplug Rusty Russell
[not found] ` <e4199103bd85fae76ce7009d7d6abacf28f1f972.1374759439.git.amit.shah@redhat.com>
2013-07-29 4:51 ` [PATCH v3 4/9] virtio: console: fix raising SIGIO after " Rusty Russell
[not found] ` <f218052d8d8438fea0d1c3483434e315c7e82db8.1374759439.git.amit.shah@redhat.com>
2013-07-29 4:53 ` [PATCH v3 5/9] virtio: console: return -ENODEV on all read operations after unplug Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802083921.GC28594@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).