From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH v3 9/9] virtio: console: prevent use-after-free of port name in port unplug Date: Fri, 2 Aug 2013 14:09:21 +0530 Message-ID: <20130802083921.GC28594@grmbl.mre> References: <83c058bc32c4e377a75235120885aec7dfd223c7.1374759439.git.amit.shah@redhat.com> <871u6i6k2e.fsf@rustcorp.com.au> <20130731081029.GB27354@grmbl.mre> <87ob9i445k.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <87ob9i445k.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Rusty Russell Cc: Virtualization List List-Id: virtualization@lists.linuxfoundation.org On (Thu) 01 Aug 2013 [10:29:35], Rusty Russell wrote: > Amit Shah writes: > > On (Mon) 29 Jul 2013 [14:26:09], Rusty Russell wrote: > >> Amit Shah writes: > >> > Remove the debugfs path before freeing port->name, to prevent a possible > >> > use-after-free. > >> > > >> > Reported-by: Jason Wang > >> > Signed-off-by: Amit Shah > >> > >> Applied, > >> Rusty. > > > > Hey Rusty, I don't see this patch in your virtio-next branch: > > > > https://git.kernel.org/cgit/linux/kernel/git/rusty/linux.git/log/?h=virtio-next > > > > The others are present there. Looks like this one got missed? > > Actually, it's in my pending-rebases branch, since it requireds things > from the fixes branch. Once the fixes branch has gone to Linus (this > week) I will merge it into the virtio-next branch then apply this on > top. Ah, thanks! > It's generally considered bad form to merge into -next branches, but > it's allowed for cases like this. But I want to make sure no changes to > fixes are required before I merge it, hence the delay for some exposure > in linux-next. Got it, thanks for the explanation! Amit