From: Asias He <asias@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com
Subject: Re: [PATCH] vhost: Drop linux/socket.h
Date: Fri, 16 Aug 2013 17:27:43 +0800 [thread overview]
Message-ID: <20130816092743.GA9918@hj.localdomain> (raw)
In-Reply-To: <20130816.003159.2033932881805410431.davem@davemloft.net>
On Fri, Aug 16, 2013 at 12:31:59AM -0700, David Miller wrote:
> From: Asias He <asias@redhat.com>
> Date: Fri, 16 Aug 2013 09:27:43 +0800
>
> > On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:
> >> From: Asias He <asias@redhat.com>
> >> Date: Thu, 15 Aug 2013 11:20:16 +0800
> >>
> >> > memcpy_fromiovec is moved to lib/iovec.c. No need to include
> >> > linux/socket.h for it.
> >> >
> >> > Signed-off-by: Asias He <asias@redhat.com>
> >>
> >> You can't do this.
> >>
> >> Because this file doesn't include the header file that
> >> provides the declaration, which is linux/uio.h
> >
> > vhost.c includes drivers/vhost/vhost.h. In drivers/vhost/vhost.h, we
> > have linux/uio.h included.
>
> Nothing in vhost.h needs linux/uio.h right? That's very poor style,
> include the header where the dependency exists which is vhost.c
We use 'struct iovec' in vhost.h which needs linux/uio.h, no?
So, how about including linux/uio.h in both vhost.c and vhost.h.
--
Asias
next prev parent reply other threads:[~2013-08-16 9:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 3:20 [PATCH] vhost: Drop linux/socket.h Asias He
2013-08-15 21:07 ` David Miller
2013-08-16 1:27 ` Asias He
2013-08-16 7:31 ` David Miller
2013-08-16 9:27 ` Asias He [this message]
2013-08-17 5:29 ` David Miller
2013-08-19 1:23 ` [PATCH v2] vhost: Include linux/uio.h instead of linux/socket.h Asias He
2013-08-19 7:24 ` Michael S. Tsirkin
2013-08-20 22:08 ` David Miller
2013-08-16 9:50 ` [PATCH] vhost: Drop linux/socket.h Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816092743.GA9918@hj.localdomain \
--to=asias@redhat.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).