From: Thomas Huth <thuth@linux.vnet.ibm.com>
To: virtualization@lists.linux-foundation.org
Subject: Virtio-net, ethtool and rx-checksumming
Date: Fri, 23 Aug 2013 08:52:52 +0200 [thread overview]
Message-ID: <20130823085252.56692143@thhw500> (raw)
Hi all,
when running "ethtool -k ethX" on a virtio-net device, it always
reports "rx-checksumming: off" with recent kernels. With older kernels
(e.g. 2.6.32), it used to report "on" instead, so this difference
caused some confusion here ("do newer guest kernels have to compute the
RX checksums now? That's certainly a bug / performance problem ...").
However, after inspecting the code a little bit, it seems to me that
this ethtool setting is not taken care of by the virtio_net driver at
all, so the values reported by ethtool seem to be rather arbitrary than
on purpose.
Now my question: Would it make sense to map the "rx-checksumming"
reporting to the VIRTIO_NET_F_GUEST_CSUM feature bit, so that the user
of the guest system can see whether the guest OS has to calculate RX
checksums or not? I guess it does not make sense to also make this
configurable during run-time, but IMHO it really would be good if at
least the reporting was available.
Regards,
Thomas Huth
reply other threads:[~2013-08-23 6:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823085252.56692143@thhw500 \
--to=thuth@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).