virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* Virtio-net, ethtool and rx-checksumming
@ 2013-08-23  6:52 Thomas Huth
  0 siblings, 0 replies; only message in thread
From: Thomas Huth @ 2013-08-23  6:52 UTC (permalink / raw)
  To: virtualization


 Hi all,

when running "ethtool -k ethX" on a virtio-net device, it always
reports "rx-checksumming: off" with recent kernels. With older kernels
(e.g. 2.6.32), it used to report "on" instead, so this difference
caused some confusion here ("do newer guest kernels have to compute the
RX checksums now? That's certainly a bug / performance problem ...").

However, after inspecting the code a little bit, it seems to me that
this ethtool setting is not taken care of by the virtio_net driver at
all, so the values reported by ethtool seem to be rather arbitrary than
on purpose.

Now my question: Would it make sense to map the "rx-checksumming"
reporting to the VIRTIO_NET_F_GUEST_CSUM feature bit, so that the user
of the guest system can see whether the guest OS has to calculate RX
checksums or not? I guess it does not make sense to also make this
configurable during run-time, but IMHO it really would be good if at
least the reporting was available.

 Regards,
  Thomas Huth

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-08-23  6:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23  6:52 Virtio-net, ethtool and rx-checksumming Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).