From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH net V2 2/2] virtio-net: refill only when device is up during setting queues
Date: Thu, 17 Oct 2013 15:55:58 -0400 (EDT) [thread overview]
Message-ID: <20131017.155558.1300032440298974117.davem@davemloft.net> (raw)
In-Reply-To: <1381807139-3450-2-git-send-email-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Tue, 15 Oct 2013 11:18:59 +0800
> We used to schedule the refill work unconditionally after changing the
> number of queues. This may lead an issue if the device is not
> up. Since we only try to cancel the work in ndo_stop(), this may cause
> the refill work still work after removing the device. Fix this by only
> schedule the work when device is up.
>
> The bug were introduce by commit 9b9cd8024a2882e896c65222aa421d461354e3f2.
> (virtio-net: fix the race between channels setting and refill)
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Applied and queued up for -stable, thanks Jason.
next prev parent reply other threads:[~2013-10-17 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 3:18 [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready Jason Wang
2013-10-15 3:18 ` [PATCH net V2 2/2] virtio-net: refill only when device is up during setting queues Jason Wang
2013-10-17 19:55 ` David Miller [this message]
2013-10-16 23:27 ` [PATCH net V2 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready Rusty Russell
2013-10-17 5:07 ` Michael S. Tsirkin
2013-10-18 1:00 ` Rusty Russell
2013-10-18 3:48 ` David Miller
2013-10-18 6:17 ` Rusty Russell
2013-10-18 7:13 ` David Miller
2013-10-17 19:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017.155558.1300032440298974117.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).