From: David Miller <davem@davemloft.net>
To: avagin@openvz.org
Cc: netdev@vger.kernel.org, mst@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory
Date: Fri, 06 Dec 2013 15:30:58 -0500 (EST) [thread overview]
Message-ID: <20131206.153058.1741013299538900621.davem@davemloft.net> (raw)
In-Reply-To: <1386254181-17257-3-git-send-email-avagin@openvz.org>
From: Andrey Vagin <avagin@openvz.org>
Date: Thu, 5 Dec 2013 18:36:21 +0400
> free_netdev calls netif_napi_del too, but it's too late, because napi
> structures are placed on vi->rq. netif_napi_add() is called from
> virtnet_alloc_queues.
...
> Fixes: 986a4f4d452d (virtio_net: multiqueue support)
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: Andrey Vagin <avagin@openvz.org>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-12-06 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386254181-17257-1-git-send-email-avagin@openvz.org>
2013-12-05 14:36 ` [PATCH 1/2] virtio-net: determine type of bufs correctly Andrey Vagin
2013-12-05 14:36 ` [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory Andrey Vagin
2013-12-05 14:54 ` [PATCH 0/2] virtio-net: Fix two bugs on unloading the module Michael S. Tsirkin
[not found] ` <1386254181-17257-2-git-send-email-avagin@openvz.org>
2013-12-05 14:52 ` [PATCH 1/2] virtio-net: determine type of bufs correctly Michael S. Tsirkin
2013-12-05 20:09 ` Michael Dalton
2013-12-06 3:20 ` Jason Wang
2013-12-07 0:35 ` Rusty Russell
2013-12-06 20:30 ` David Miller
[not found] ` <1386254181-17257-3-git-send-email-avagin@openvz.org>
2013-12-05 14:53 ` [PATCH 2/2] virtio: delete napi structures from netdev before releasing memory Michael S. Tsirkin
2013-12-06 3:21 ` Jason Wang
2013-12-07 0:32 ` Rusty Russell
2013-12-06 20:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206.153058.1741013299538900621.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).