From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Josh Boyer <jwboyer@fedoraproject.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
John McCutchan <john@johnmccutchan.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
Robert Love <rlove@rlove.org>, Eric Paris <eparis@parisplace.org>,
Brian Lane <bcl@redhat.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: virt_blk BUG: sleeping function called from invalid context
Date: Mon, 30 Jun 2014 16:17:41 -0400 [thread overview]
Message-ID: <20140630201741.GA20853@htj.dyndns.org> (raw)
In-Reply-To: <53B07D48.60003@kernel.dk>
On Sun, Jun 29, 2014 at 02:55:36PM -0600, Jens Axboe wrote:
> > commit d911d98748018f7c8facc035ba39c30f5cce6f9c
> > Author: Tejun Heo <tj@kernel.org>
> > Date: Wed Apr 9 11:07:31 2014 -0400
> >
> > kernfs: make kernfs_notify() trigger inotify events too
> >
> > Tejun, what do you think?
> >
> > Josh, Brian, could you try reverting that commit to see if it helps?
>
> That definitely be a bug. If you need to block off ->bi_end_io(), just
> must punt to a worker thread.
Ugh... didn't realize we had users triggering sysfs notifications from
an atomic context. fsnotify support requires sleepable context.
Guess I'll have to punt it to a work item. :(
Thanks.
--
tejun
next prev parent reply other threads:[~2014-06-30 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+5PVA4h2hQJLrAm4eEZ8oUgGiAjq2y5eAyBcJWxK_FiQXnuQg@mail.gmail.com>
2014-06-29 8:26 ` virt_blk BUG: sleeping function called from invalid context Michael S. Tsirkin
2014-06-29 19:32 ` Christoph Hellwig
[not found] ` <20140629193222.GA7030@lst.de>
2014-06-29 20:47 ` Michael S. Tsirkin
2014-06-29 20:55 ` Jens Axboe
2014-06-30 20:17 ` Tejun Heo [this message]
2014-07-01 20:41 ` [PATCH driver-core-linus] kernfs: kernfs_notify() must be useable from non-sleepable contexts Tejun Heo
2014-07-01 20:51 ` Greg Kroah-Hartman
2014-07-02 14:14 ` Tejun Heo
2014-07-02 16:31 ` Greg Kroah-Hartman
2014-07-02 5:53 ` Michael S. Tsirkin
2014-06-27 11:57 virt_blk BUG: sleeping function called from invalid context Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630201741.GA20853@htj.dyndns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bcl@redhat.com \
--cc=eparis@parisplace.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=john@johnmccutchan.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rlove@rlove.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).