From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amit Shah Subject: Re: [PATCH v3 0/2] hwrng, virtio-rng: init-time fixes Date: Tue, 15 Jul 2014 10:10:28 +0530 Message-ID: <20140715044028.GA26186@grmbl.mre> References: <20140714125006.GA9958@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20140714125006.GA9958@gondor.apana.org.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Herbert Xu Cc: jason@lakedaemon.net, linux-kernel@vger.kernel.org, keescook@chromium.org, Virtualization List List-Id: virtualization@lists.linuxfoundation.org On (Mon) 14 Jul 2014 [20:50:06], Herbert Xu wrote: > On Thu, Jul 10, 2014 at 03:42:33PM +0530, Amit Shah wrote: > > v3: > > - Kees Cook pointed out a weird side-effect: devices which have > > ->init() registered get their randomness added to the system each > > time they're switched in, but devices that don't have the init > > callback don't contribute to system randomness more than once. The > > weirdness is resolved here by using the randomness each time > > hwrng_init() is attempted, irrespective of the existence of the > > device's ->init() callback. > > All applied to crypto. Thanks! Thanks, Herbert. I didn't mention it, but pls queue it up for 3.16. Amit