From: Amit Shah <amit.shah@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Virtualization List <virtualization@lists.linux-foundation.org>,
Jason Cooper <jason@lakedaemon.net>,
keescook@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] hw_random: allow RNG devices to give early randomness after a delay
Date: Fri, 18 Jul 2014 14:57:37 +0530 [thread overview]
Message-ID: <20140718092737.GD15020@grmbl.mre> (raw)
In-Reply-To: <20140718091408.GA17266@gondor.apana.org.au>
On (Fri) 18 Jul 2014 [17:14:08], Herbert Xu wrote:
> On Fri, Jul 18, 2014 at 02:26:26PM +0530, Amit Shah wrote:
> >
> > > Sounds like a good idea to me. Though, changes in core.c that
> > > increase the time in hwrng_register() or hwrng_init() may not get
> > > noticed by rng drivers and they may suddenly start failing for no
> > > apparent reason. Seems like a far stretch, though. Does anyone else
> > > have an opinion on this?
> >
> > Herbert, do you have any preference?
>
> So it's only virtio-rng that's a problem, right? How about if we
> abuse the scan hook in virtio and move the hwrng_register there?
Oops, I had completely missed the scan hook, and looks like it was
added for exactly the purpose we want here (so we won't even be
abusing it!)
Thanks!
I'll post the patches when the one to revert gets an upstream commit
id.
Amit
next prev parent reply other threads:[~2014-07-18 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 4:35 [RFC PATCH 0/3] hw_random: support for delayed init randomness requests Amit Shah
2014-07-14 4:35 ` [RFC PATCH 1/3] hw_random: allow RNG devices to give early randomness after a delay Amit Shah
2014-07-14 12:37 ` Jason Cooper
2014-07-14 12:42 ` Amit Shah
2014-07-18 8:56 ` Amit Shah
2014-07-18 9:14 ` Herbert Xu
2014-07-18 9:27 ` Amit Shah [this message]
2014-07-14 4:35 ` [RFC PATCH 2/3] virtio: rng: only accept delayed early randomness requests Amit Shah
2014-07-14 4:35 ` [RFC PATCH 3/3] Revert "virtio: rng: ensure reads happen after successful probe" Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718092737.GD15020@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).