From: Amit Shah <amit.shah@redhat.com>
To: Jason Cooper <jason@lakedaemon.net>
Cc: herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org,
Virtualization List <virtualization@lists.linux-foundation.org>,
keescook@chromium.org
Subject: Re: [PATCH v2 0/4] virtio-rng: contribute to early randomness requests
Date: Tue, 22 Jul 2014 20:38:15 +0530 [thread overview]
Message-ID: <20140722150815.GF32103@grmbl.mre> (raw)
In-Reply-To: <20140722114623.GC18750@titan.lakedaemon.net>
On (Tue) 22 Jul 2014 [07:46:23], Jason Cooper wrote:
> On Mon, Jul 21, 2014 at 05:15:48PM +0530, Amit Shah wrote:
> > v2:
> > - update patch 3 to store the hwrng_register_done bool per-device
> > rather than global
> > - add patch 2 that re-arranges struct elems for better packing.
> >
> > Hi,
> >
> > This series enables virtio-rng to service the early randomness
> > requests made by the hwrng core (patch 3), with Herbert's idea of
> > using the scan routine.
> >
> > Patch 4 reverts the previous restriction, which no longer applies, to
> > not send read requests to the host before successful probe.
> >
> > Patches 1 and 2 are minor cleanups.
> >
> > Please review and apply,
> >
> > Amit Shah (4):
> > virtio: rng: remove unused struct element
> > virtio: rng: re-arrange struct elements for better packing
> > virtio: rng: delay hwrng_register() till driver is ready
> > Revert "hwrng: virtio - ensure reads happen after successful probe"
> >
> > drivers/char/hw_random/core.c | 6 ------
> > drivers/char/hw_random/virtio-rng.c | 39 ++++++++++++++++---------------------
> > 2 files changed, 17 insertions(+), 28 deletions(-)
>
> fwiw,
>
> Reviewed-by: Jason Cooper <jason@lakedaemon.net>
>
> Thanks for putting this together Amit!
Thanks, Jason!
Amit
prev parent reply other threads:[~2014-07-22 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 11:45 [PATCH v2 0/4] virtio-rng: contribute to early randomness requests Amit Shah
2014-07-21 11:45 ` [PATCH v2 1/4] virtio: rng: remove unused struct element Amit Shah
2014-07-21 11:45 ` [PATCH v2 2/4] virtio: rng: re-arrange struct elements for better packing Amit Shah
2014-07-21 11:45 ` [PATCH v2 3/4] virtio: rng: delay hwrng_register() till driver is ready Amit Shah
2014-07-21 12:11 ` Jason Cooper
2014-07-21 12:21 ` Amit Shah
2014-07-21 12:41 ` Herbert Xu
2014-07-22 11:43 ` Jason Cooper
2014-07-22 17:08 ` Amit Shah
2014-07-23 5:51 ` Rusty Russell
2014-07-21 11:45 ` [PATCH v2 4/4] Revert "hwrng: virtio - ensure reads happen after successful probe" Amit Shah
2014-07-22 11:46 ` [PATCH v2 0/4] virtio-rng: contribute to early randomness requests Jason Cooper
2014-07-22 15:08 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722150815.GF32103@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).