From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file Date: Sun, 14 Sep 2014 17:11:58 +0300 Message-ID: <20140914141158.GA27836@redhat.com> References: <1410448173-12960-1-git-send-email-kraxel@redhat.com> <1410448173-12960-2-git-send-email-kraxel@redhat.com> <5411BD74.80608@redhat.com> <1410518696.30411.9.camel@nilsson.home.kraxel.org> <20140914134622.GB27315@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Peter Maydell Cc: QEMU Developers , Dave Airlie , virtio-dev@lists.oasis-open.org, "virtualization@lists.linux-foundation.org" List-Id: virtualization@lists.linuxfoundation.org On Sun, Sep 14, 2014 at 07:04:11AM -0700, Peter Maydell wrote: > On 14 September 2014 06:46, Michael S. Tsirkin wrote: > > BUILD_BUG_ON in linux, QEMU_BUILD_BUG_ON in QEMU. > > You have to stick it in a C file though, so it > > won't be visible in this patch. > > Why do you think that? We have several header files which > use QEMU_BUILD_BUG_ON and I don't see any reason why > it would have to be invoked from a .c file. > > -- PMM Because Gerd wants to share this with linux uapi, and you can't use BUILD_BUG_ON in uapi headers on linux.