From: Tejun Heo <tj@kernel.org>
To: Petr Mladek <pmladek@suse.cz>
Cc: Jiri Kosina <jkosina@suse.cz>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio_balloon: Convert "vballon" kthread into a workqueue
Date: Sun, 28 Sep 2014 08:43:18 -0400 [thread overview]
Message-ID: <20140928124318.GA3736@mtj.dyndns.org> (raw)
In-Reply-To: <1411662041-10986-1-git-send-email-pmladek@suse.cz>
On Thu, Sep 25, 2014 at 06:20:41PM +0200, Petr Mladek wrote:
...
> 1st create_freezable_workqueue("vballoon_wq");
All create_*workqueue() interfaces are deprecated. Please don't
create new usages. They map to alloc_*workqueue() anyway.
> 2nd alloc_workqueue("vballoon_wq", WQ_FREEZABLE | WQ_MEM_RECLAIM, 0);
Is WQ_MEM_RECLAIM necessary here? Does virtio_balloon depended upon
from memory allocation path?
...
> The 2nd way to create the workqueue has about the same results as kthread.
> This is why it is used in the patch.
You're testing WQ_UNBOUND vs. !WQ_UNBOUND and yes for most use cases,
!WQ_UNBOUND will be more efficient. The right thing to do in most
cases is using alloc_workqueue() w/ as minimum extra flags as
possible.
Thanks!
--
tejun
next parent reply other threads:[~2014-09-28 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1411662041-10986-1-git-send-email-pmladek@suse.cz>
2014-09-28 12:43 ` Tejun Heo [this message]
2014-10-15 5:10 ` [PATCH] virtio_balloon: Convert "vballon" kthread into a workqueue Rusty Russell
2014-09-25 16:20 Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928124318.GA3736@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pmladek@suse.cz \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).