From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH RFC 00/11] qemu: towards virtio-1 host support Date: Thu, 23 Oct 2014 12:18:16 +0300 Message-ID: <20141023091816.GB6287@redhat.com> References: <1412692807-12398-1-git-send-email-cornelia.huck@de.ibm.com> <54349246.6000905@amacapital.net> <20141008110428.6fc78115.cornelia.huck@de.ibm.com> <20141022084438.GA8051@redhat.com> <5447BC84.1010402@siemens.com> <1414010056.364.20.camel@pasglop> <5448A3B9.4050400@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5448A3B9.4050400@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jan Kiszka Cc: thuth@linux.vnet.ibm.com, kvm@vger.kernel.org, Benjamin Herrenschmidt , qemu-devel@nongnu.org, Andy Lutomirski , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Thu, Oct 23, 2014 at 08:44:09AM +0200, Jan Kiszka wrote: > On 2014-10-22 22:34, Benjamin Herrenschmidt wrote: > > On Wed, 2014-10-22 at 16:17 +0200, Jan Kiszka wrote: > >> I thought about this again, and I'm not sure anymore if we can use > >> ACPI > >> to "black-list" the incompatible virtio devices. Reason: hotplug. To > >> my > >> understanding, the ACPI DRHD tables won't change during runtime when a > >> device shows up or disappears. We would have to isolate virtio devices > >> from the rest of the system by using separate buses for it (and avoid > >> listing those in any DRHD table) and enforce that they only get > >> plugged > >> into those buses. I suppose that is not desirable. > >> > >> Maybe it's better to fix virtio /wrt IOMMUs. > > > > I always go back to my initial proposal which is to define that current > > virtio always bypass any iommu (which is what it does really) and have > > it expose via a new capability if that isn't the case. That means fixing > > that Xen thingy to allow qemu to know what to expose I assume but that > > seems to be the less bad approach. > > Just one thing to consider: feature negotiation happens after guest > startup. If we run a virtio device under IOMMU control, what will we > have to do when the guest says it does not support such devices? Simply > reject operation? > > Jan We could restrict this to the new set of device IDs that got introduced in virtio 1.0. That actually has a mechanism for devices to gracefully reject a combination of features if we still need it. > -- > Siemens AG, Corporate Technology, CT RTC ITP SES-DE > Corporate Competence Center Embedded Linux