From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Hildenbrand Subject: Re: [PATCH v5 01/45] virtio: use u32, not bitmap for struct virtio_device's features Date: Thu, 27 Nov 2014 17:34:14 +0100 Message-ID: <20141127173414.20424b62@thinkpad-w530> References: <1417091078-24611-1-git-send-email-mst@redhat.com> <1417091078-24611-2-git-send-email-mst@redhat.com> <20141127171542.3dbb2bc2@thinkpad-w530> <20141127162804.GB27124@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141127162804.GB27124@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: rusty@au1.ibm.com, Heiko Carstens , Sudeep Dutt , virtualization@lists.linux-foundation.org, linux-s390@vger.kernel.org, lguest@lists.ozlabs.org, Arnd Bergmann , Christian Borntraeger , Joel Stanley , Pawel Moll , Siva Yerramreddy , Martin Schwidefsky , pbonzini@redhat.com, thuth@linux.vnet.ibm.com, Brian Swetland , linux-kernel@vger.kernel.org, Ashutosh Dixit , Greg Kroah-Hartman , Amit Shah , linux390@de.ibm.com, David Miller List-Id: virtualization@lists.linuxfoundation.org > That's the whole reason for the patch. > > I guess you disagree with it, but it's much easier > to deal with simple integers. > Well, I can live with it :) clear_bit() and friends are just easier to understand when scanning the code (at least for me).