From: Amit Shah <amit.shah@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 12/25] virtio_console: Use bool function return values of true/false not 1/0
Date: Tue, 31 Mar 2015 11:02:39 +0530 [thread overview]
Message-ID: <20150331053239.GA9916@grmbl.mre> (raw)
In-Reply-To: <aa2bc094fb872b0e30703e0ad1bbe97f98bae91d.1427759009.git.joe@perches.com>
On (Mon) 30 Mar 2015 [16:46:10], Joe Perches wrote:
> Use the normal return values for bool functions
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/char/virtio_console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
> index 72d7028..50754d20 100644
> --- a/drivers/char/virtio_console.c
> +++ b/drivers/char/virtio_console.c
> @@ -355,7 +355,7 @@ static inline bool use_multiport(struct ports_device *portdev)
> * early_init
> */
> if (!portdev->vdev)
> - return 0;
> + return false;
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
prev parent reply other threads:[~2015-03-31 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1427759009.git.joe@perches.com>
2015-03-30 23:46 ` [PATCH 12/25] virtio_console: Use bool function return values of true/false not 1/0 Joe Perches
2015-03-31 0:07 ` [PATCH 00/25] treewide: " Casey Schaufler
[not found] ` <5519E53B.5040504@schaufler-ca.com>
2015-03-31 0:14 ` Joe Perches
[not found] ` <aa2bc094fb872b0e30703e0ad1bbe97f98bae91d.1427759009.git.joe@perches.com>
2015-03-31 5:32 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150331053239.GA9916@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).