Re: [PATCH v5 7/8] vhost: cross-endian support for legacy devices

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Fri, 24 Apr 2015 10:06:19 +0200
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:

> On Fri, 24 Apr 2015 09:19:26 +0200
> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
> 
> > On Thu, 23 Apr 2015 17:29:42 +0200
> > Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:

> > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
> > > index bb6a5b4..b980b53 100644
> > > --- a/include/uapi/linux/vhost.h
> > > +++ b/include/uapi/linux/vhost.h
> > > @@ -103,6 +103,18 @@ struct vhost_memory {
> > >  /* Get accessor: reads index, writes value in num */
> > >  #define VHOST_GET_VRING_BASE _IOWR(VHOST_VIRTIO, 0x12, struct vhost_vring_state)
> > > 
> > > +/* Set the vring byte order in num. Valid values are VHOST_VRING_LITTLE_ENDIAN
> > > + * or VHOST_VRING_BIG_ENDIAN (other values return EINVAL).
> > 
> > -EINVAL?
> > 
> 
> Oops, yes. :)
> 
> > Should you also mention when you return -EBUSY?
> > 
> 
> Indeed... what about:
> 
> "The byte order cannot be changed when the device is active: trying to do so
> returns -EBUSY."

s/when/while/ ?

But sounds good.