* [PATCH] virtio_pci: Clear stale cpumask when setting irq affinity
@ 2015-06-04 8:41 Jiang Liu
2015-06-04 12:55 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Jiang Liu @ 2015-06-04 8:41 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, Thomas Gleixner, Jiang Liu, virtualization
The cpumask vp_dev->msix_affinity_masks[info->msix_vector] may contain
staled information when vp_set_vq_affinity() gets called, so clear it
before setting the new cpu bit mask.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
drivers/virtio/virtio_pci_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
index e894eb278d83..eba1b7ac7294 100644
--- a/drivers/virtio/virtio_pci_common.c
+++ b/drivers/virtio/virtio_pci_common.c
@@ -423,6 +423,7 @@ int vp_set_vq_affinity(struct virtqueue *vq, int cpu)
if (cpu == -1)
irq_set_affinity_hint(irq, NULL);
else {
+ cpumask_clear(mask);
cpumask_set_cpu(cpu, mask);
irq_set_affinity_hint(irq, mask);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] virtio_pci: Clear stale cpumask when setting irq affinity
2015-06-04 8:41 [PATCH] virtio_pci: Clear stale cpumask when setting irq affinity Jiang Liu
@ 2015-06-04 12:55 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-06-04 12:55 UTC (permalink / raw)
To: Jiang Liu; +Cc: Thomas Gleixner, linux-kernel, virtualization
On Thu, Jun 04, 2015 at 04:41:44PM +0800, Jiang Liu wrote:
> The cpumask vp_dev->msix_affinity_masks[info->msix_vector] may contain
> staled information when vp_set_vq_affinity() gets called, so clear it
> before setting the new cpu bit mask.
>
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
I have queued this up.
Thanks!
> ---
> drivers/virtio/virtio_pci_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
> index e894eb278d83..eba1b7ac7294 100644
> --- a/drivers/virtio/virtio_pci_common.c
> +++ b/drivers/virtio/virtio_pci_common.c
> @@ -423,6 +423,7 @@ int vp_set_vq_affinity(struct virtqueue *vq, int cpu)
> if (cpu == -1)
> irq_set_affinity_hint(irq, NULL);
> else {
> + cpumask_clear(mask);
> cpumask_set_cpu(cpu, mask);
> irq_set_affinity_hint(irq, mask);
> }
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-04 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-04 8:41 [PATCH] virtio_pci: Clear stale cpumask when setting irq affinity Jiang Liu
2015-06-04 12:55 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).