virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Suman Anna <s-anna@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers
Date: Thu, 26 Nov 2015 12:37:00 +0200	[thread overview]
Message-ID: <20151126103700.GA13200@redhat.com> (raw)
In-Reply-To: <CAK=WgbaYdUU8o-iAqJAOuTd_cXzkcYQ0Nt14beuZ=PwtXGtV3A@mail.gmail.com>

On Thu, Nov 26, 2015 at 11:38:06AM +0200, Ohad Ben-Cohen wrote:
> Hi Suman,
> 
> On Thu, Sep 17, 2015 at 3:29 AM, Suman Anna <s-anna@ti.com> wrote:
> > The remoteproc core uses a static ida named rproc_dev_index for
> > assigning an automatic index number to a registered remoteproc.
> > The ida core may allocate some internal idr cache layers and ida
> > bitmap upon any ida allocation, and all these layers are truely
> > freed only upon the ida destruction. The rproc_dev_index ida is
> > not destroyed at present, leading to a memory leak when using the
> > remoteproc core as a module and atleast one rproc device is
> > registered and unregistered.
> >
> > Fix this by invoking ida_destroy() in the remoteproc core module
> > exit.
> 
> I saw there was some discussion about this between Michael, James and
> Tejun whether this should be fixed in the IDA core or not.
> 
> Has it been resolved?
> 
> Thanks,
> Ohad.

I don't think we reached any conclusions.
I guess I'll merge the virtio patch as-is then.
Ohad, would you like to merge 2/2?

-- 
MST

  reply	other threads:[~2015-11-26 10:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  0:29 [PATCH 0/2] Fix memory leaks in virtio & remoteproc cores Suman Anna
2015-09-17  0:29 ` [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers Suman Anna
2015-09-17  0:29 ` [PATCH 2/2] remoteproc: fix memory leak of remoteproc " Suman Anna
2015-11-26  9:38   ` Ohad Ben-Cohen
2015-11-26 10:37     ` Michael S. Tsirkin [this message]
2015-11-26 15:47       ` Ohad Ben-Cohen
     [not found] ` <1442449758-14594-2-git-send-email-s-anna@ti.com>
2015-09-17  5:33   ` DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers) Michael S. Tsirkin
2015-09-17  6:51     ` Hannes Reinecke
     [not found]     ` <1442499344.4073.0.camel@HansenPartnership.com>
2015-09-17 15:10       ` Tejun Heo
2015-09-17 16:06       ` Michael S. Tsirkin
     [not found]         ` <1442508517.4073.13.camel@HansenPartnership.com>
2015-09-17 17:15           ` Tejun Heo
     [not found]           ` <20150917171529.GA15447@htj.duckdns.org>
     [not found]             ` <1442512709.4073.24.camel@HansenPartnership.com>
2015-09-17 18:00               ` Tejun Heo
     [not found]     ` <55FA630A.4020707@suse.de>
2015-09-17 22:32       ` Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151126103700.GA13200@redhat.com \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).