From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 2/2] remoteproc: fix memory leak of remoteproc ida cache layers Date: Thu, 26 Nov 2015 12:37:00 +0200 Message-ID: <20151126103700.GA13200@redhat.com> References: <1442449758-14594-1-git-send-email-s-anna@ti.com> <1442449758-14594-3-git-send-email-s-anna@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Ohad Ben-Cohen Cc: Suman Anna , "linux-kernel@vger.kernel.org" , virtualization List-Id: virtualization@lists.linuxfoundation.org On Thu, Nov 26, 2015 at 11:38:06AM +0200, Ohad Ben-Cohen wrote: > Hi Suman, > > On Thu, Sep 17, 2015 at 3:29 AM, Suman Anna wrote: > > The remoteproc core uses a static ida named rproc_dev_index for > > assigning an automatic index number to a registered remoteproc. > > The ida core may allocate some internal idr cache layers and ida > > bitmap upon any ida allocation, and all these layers are truely > > freed only upon the ida destruction. The rproc_dev_index ida is > > not destroyed at present, leading to a memory leak when using the > > remoteproc core as a module and atleast one rproc device is > > registered and unregistered. > > > > Fix this by invoking ida_destroy() in the remoteproc core module > > exit. > > I saw there was some discussion about this between Michael, James and > Tejun whether this should be fixed in the IDA core or not. > > Has it been resolved? > > Thanks, > Ohad. I don't think we reached any conclusions. I guess I'll merge the virtio patch as-is then. Ohad, would you like to merge 2/2? -- MST