From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next 0/3] basic busy polling support for vhost_net
Date: Mon, 30 Nov 2015 10:22:59 +0200 [thread overview]
Message-ID: <20151130102219-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151129.223110.1579432138646337508.davem@davemloft.net>
On Sun, Nov 29, 2015 at 10:31:10PM -0500, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Wed, 25 Nov 2015 15:11:26 +0800
>
> > This series tries to add basic busy polling for vhost net. The idea is
> > simple: at the end of tx/rx processing, busy polling for new tx added
> > descriptor and rx receive socket for a while. The maximum number of
> > time (in us) could be spent on busy polling was specified ioctl.
> >
> > Test A were done through:
> >
> > - 50 us as busy loop timeout
> > - Netperf 2.6
> > - Two machines with back to back connected ixgbe
> > - Guest with 1 vcpu and 1 queue
> >
> > Results:
> > - For stream workload, ioexits were reduced dramatically in medium
> > size (1024-2048) of tx (at most -43%) and almost all rx (at most
> > -84%) as a result of polling. This compensate for the possible
> > wasted cpu cycles more or less. That porbably why we can still see
> > some increasing in the normalized throughput in some cases.
> > - Throughput of tx were increased (at most 50%) expect for the huge
> > write (16384). And we can send more packets in the case (+tpkts were
> > increased).
> > - Very minor rx regression in some cases.
> > - Improvemnt on TCP_RR (at most 17%).
>
> Michael are you going to take this? It's touching vhost core as
> much as it is the vhost_net driver.
There's a minor bug there, but once it's fixed - I agree,
it belongs in the vhost tree.
--
MST
prev parent reply other threads:[~2015-11-30 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 7:11 [PATCH net-next 0/3] basic busy polling support for vhost_net Jason Wang
2015-11-25 7:11 ` [PATCH net-next 1/3] vhost: introduce vhost_has_work() Jason Wang
2015-11-25 7:11 ` [PATCH net-next 2/3] vhost: introduce vhost_vq_more_avail() Jason Wang
2015-11-30 8:22 ` Michael S. Tsirkin
[not found] ` <20151130082202.GA7396@redhat.com>
2015-12-01 5:14 ` Jason Wang
2015-11-25 7:11 ` [PATCH net-next 3/3] vhost_net: basic polling support Jason Wang
2015-11-30 10:44 ` Michael S. Tsirkin
2015-12-01 5:17 ` Jason Wang
[not found] ` <565D2D7D.4010903@redhat.com>
2015-12-01 14:43 ` Michael S. Tsirkin
2015-12-02 5:04 ` Jason Wang
[not found] ` <565E7BC3.2060107@redhat.com>
2015-12-02 12:36 ` Michael S. Tsirkin
[not found] ` <20151202143522-mutt-send-email-mst@redhat.com>
2015-12-04 2:24 ` Jason Wang
2015-11-30 3:31 ` [PATCH net-next 0/3] basic busy polling support for vhost_net David Miller
2015-11-30 8:22 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130102219-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).