virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: linux-arch@vger.kernel.org, arnd@arndb.de,
	stefano.stabellini@eu.citrix.com, peterz@infradead.org,
	andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 00/34] arch: barrier cleanup + __smp_xxx barriers for virt
Date: Wed, 30 Dec 2015 16:59:08 -0500 (EST)	[thread overview]
Message-ID: <20151230.165908.1627575055770897057.davem@davemloft.net> (raw)
In-Reply-To: <20151230224855-mutt-send-email-mst@redhat.com>

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 30 Dec 2015 23:36:29 +0200

> On Wed, Dec 30, 2015 at 03:46:46PM -0500, David Miller wrote:
>> From: "Michael S. Tsirkin" <mst@redhat.com>
>> Date: Wed, 30 Dec 2015 14:58:19 +0200
>> 
>> > -. Patch 1 documents the __smp APIs, and explains why they are
>> >    useful for virt
>> 
>> If virt is doing things like interacting with descriptors that are
>> shared with a (potentially SMP) host, why don't we just annotate those
>> specific cases?
> 
> Using a bunch of per-arch ifdefs in virtio?
> That's fundamentally what we have now.

I was suggesting a generic interface to get what you want.

virt_mb() or something like that.  You can name it something
else, that's not the important part.

> Or do you mean wrappers for __smp_XXX that explicitly
> say they are for talking to host?
> E.g. pv_mb() pv_rmb() etc.
> That sounds very reasonable to me.

Exactly!

  parent reply	other threads:[~2015-12-30 21:59 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30 13:24 [PATCH 00/34] arch: barrier cleanup + __smp_XXX barriers for virt Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 01/34] Documentation/memory-barriers.txt: document __smb_mb() Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 02/34] asm-generic: guard smp_store_release/load_acquire Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 03/34] ia64: rename nop->iosapic_nop Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 04/34] ia64: reuse asm-generic/barrier.h Michael S. Tsirkin
2015-12-30 16:41   ` Luck, Tony
2015-12-30 13:24 ` [PATCH 05/34] powerpc: " Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 06/34] s390: " Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 07/34] sparc: " Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 08/34] asm-generic: smp_store_mb should use smp_mb Michael S. Tsirkin
2015-12-30 13:44   ` Arnd Bergmann
     [not found]   ` <5946017.BCmPrpGMuh@wuerfel>
2015-12-30 20:30     ` Michael S. Tsirkin
     [not found]     ` <20151230222703-mutt-send-email-mst@redhat.com>
2015-12-30 22:43       ` Arnd Bergmann
2015-12-30 13:24 ` [PATCH 09/34] arm: reuse asm-generic/barrier.h Michael S. Tsirkin
2015-12-30 13:24 ` [PATCH 10/34] arm64: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 11/34] metag: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 12/34] mips: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 13/34] x86/um: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 14/34] x86: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 15/34] asm-generic: add __smp_XXX wrappers Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 16/34] powerpc: define __smp_XXX Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 17/34] arm64: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 18/34] arm: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 19/34] blackfin: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 20/34] ia64: " Michael S. Tsirkin
2015-12-30 16:43   ` Luck, Tony
2015-12-30 13:25 ` [PATCH 21/34] metag: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 22/34] mips: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 23/34] s390: " Michael S. Tsirkin
2015-12-30 13:25 ` [PATCH 24/34] sh: define __smp_XXX, fix smp_store_mb for !SMP Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 25/34] sparc: define __smp_XXX Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 26/34] tile: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 27/34] xtensa: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 28/34] x86: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 29/34] Revert "virtio_ring: Update weak barriers to use dma_wmb/rmb" Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 30/34] virtio_ring: update weak barriers to use __smp_XXX Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 31/34] xenbus: use __smp_XXX barriers Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 32/34] xen/io: " Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 33/34] virtio: use __smp_load_acquire/__smp_store_release Michael S. Tsirkin
2015-12-30 13:26 ` [PATCH 34/34] virtio_ring: use __smp_store_mb Michael S. Tsirkin
2015-12-30 13:49 ` [PATCH 00/34] arch: barrier cleanup + __smp_XXX barriers for virt Arnd Bergmann
2015-12-30 21:45   ` [PATCH 00/34] arch: barrier cleanup + __smp_xxx " Michael S. Tsirkin
     [not found]   ` <20151230234521-mutt-send-email-mst@redhat.com>
2015-12-30 22:45     ` Arnd Bergmann
     [not found] ` <1451473761-30019-4-git-send-email-mst@redhat.com>
2015-12-30 16:39   ` [PATCH 03/34] ia64: rename nop->iosapic_nop Luck, Tony
     [not found] ` <1451473761-30019-8-git-send-email-mst@redhat.com>
2015-12-30 17:56   ` [PATCH 07/34] sparc: reuse asm-generic/barrier.h David Miller
     [not found]   ` <20151230.125603.75638711551088484.davem@davemloft.net>
2015-12-30 19:55     ` Michael S. Tsirkin
2015-12-30 20:47       ` David Miller
2015-12-30 20:46 ` [PATCH 00/34] arch: barrier cleanup + __smp_xxx barriers for virt David Miller
2015-12-30 21:36   ` Michael S. Tsirkin
     [not found]   ` <20151230224855-mutt-send-email-mst@redhat.com>
2015-12-30 21:59     ` David Miller [this message]
     [not found] ` <1451473761-30019-2-git-send-email-mst@redhat.com>
2016-01-04 11:08   ` [PATCH 01/34] Documentation/memory-barriers.txt: document __smb_mb() Stefano Stabellini
     [not found]   ` <alpine.DEB.2.02.1601041104290.19710@kaball.uk.xensource.com>
2016-01-04 11:27     ` Michael S. Tsirkin
     [not found] ` <1451473761-30019-32-git-send-email-mst@redhat.com>
2016-01-04 11:58   ` [PATCH 31/34] xenbus: use __smp_XXX barriers Stefano Stabellini
     [not found] ` <1451473761-30019-33-git-send-email-mst@redhat.com>
2016-01-04 11:59   ` [PATCH 32/34] xen/io: " Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151230.165908.1627575055770897057.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew.cooper3@citrix.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=peterz@infradead.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).