From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
virtualization@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Davidlohr Bueso <dave@stgolabs.net>,
Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, Christian Borntraeger <borntraeger@de.ibm.com>,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@elte.hu>,
linux-xtensa@linux-xtensa.org,
user-mode-linux-devel@lists.sourceforge.net,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrey Konovalov <andreyknvl@google.com>,
adi-buildroot-devel@lists.sourceforge.net,
Thomas Gleixner <tglx@linutronix.de>,
linux-metag@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Andrew
Subject: Re: [PATCH v2 06/32] s390: reuse asm-generic/barrier.h
Date: Tue, 5 Jan 2016 09:03:01 +0100 [thread overview]
Message-ID: <20160105090301.3f9939be@mschwide> (raw)
In-Reply-To: <20160104224135-mutt-send-email-mst@redhat.com>
On Mon, 4 Jan 2016 22:42:44 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Mon, Jan 04, 2016 at 04:03:39PM +0100, Martin Schwidefsky wrote:
> > On Mon, 4 Jan 2016 14:20:42 +0100
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > On Thu, Dec 31, 2015 at 09:06:30PM +0200, Michael S. Tsirkin wrote:
> > > > On s390 read_barrier_depends, smp_read_barrier_depends
> > > > smp_store_mb(), smp_mb__before_atomic and smp_mb__after_atomic match the
> > > > asm-generic variants exactly. Drop the local definitions and pull in
> > > > asm-generic/barrier.h instead.
> > > >
> > > > This is in preparation to refactoring this code area.
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > > ---
> > > > arch/s390/include/asm/barrier.h | 10 ++--------
> > > > 1 file changed, 2 insertions(+), 8 deletions(-)
> > > >
> > > > diff --git a/arch/s390/include/asm/barrier.h b/arch/s390/include/asm/barrier.h
> > > > index 7ffd0b1..c358c31 100644
> > > > --- a/arch/s390/include/asm/barrier.h
> > > > +++ b/arch/s390/include/asm/barrier.h
> > > > @@ -30,14 +30,6 @@
> > > > #define smp_rmb() rmb()
> > > > #define smp_wmb() wmb()
> > > >
> > > > -#define read_barrier_depends() do { } while (0)
> > > > -#define smp_read_barrier_depends() do { } while (0)
> > > > -
> > > > -#define smp_mb__before_atomic() smp_mb()
> > > > -#define smp_mb__after_atomic() smp_mb()
> > >
> > > As per:
> > >
> > > lkml.kernel.org/r/20150921112252.3c2937e1@mschwide
> > >
> > > s390 should change this to barrier() instead of smp_mb() and hence
> > > should not use the generic versions.
> >
> > Yes, we wanted to simplify this. Thanks for the reminder, I'll queue
> > a patch.
>
> Could you base on my patchset maybe, to avoid conflicts,
> and I'll merge it?
> Or if it's just replacing these 2 with barrier() I can do this
> myself easily.
Probably the easiest solution if you do the patch yourself and
include it in your patch set.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2016-01-05 8:03 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 19:05 [PATCH v2 00/34] arch: barrier cleanup + barriers for virt Michael S. Tsirkin
2015-12-31 19:05 ` [PATCH v2 01/32] lcoking/barriers, arch: Use smp barriers in smp_store_release() Michael S. Tsirkin
2015-12-31 19:05 ` [PATCH v2 02/32] asm-generic: guard smp_store_release/load_acquire Michael S. Tsirkin
2015-12-31 19:06 ` [PATCH v2 03/32] ia64: rename nop->iosapic_nop Michael S. Tsirkin
2015-12-31 19:06 ` [PATCH v2 04/32] ia64: reuse asm-generic/barrier.h Michael S. Tsirkin
2015-12-31 19:06 ` [PATCH v2 05/32] powerpc: " Michael S. Tsirkin
2015-12-31 19:06 ` [PATCH v2 06/32] s390: " Michael S. Tsirkin
2015-12-31 19:06 ` [PATCH v2 07/32] sparc: " Michael S. Tsirkin
2015-12-31 19:06 ` [PATCH v2 08/32] arm: " Michael S. Tsirkin
2015-12-31 19:06 ` [PATCH v2 09/32] arm64: " Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 10/32] metag: " Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 11/32] mips: " Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 12/32] x86/um: " Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 13/32] x86: " Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 14/32] asm-generic: add __smp_xxx wrappers Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 15/32] powerpc: define __smp_xxx Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 16/32] arm64: " Michael S. Tsirkin
2015-12-31 19:07 ` [PATCH v2 17/32] arm: " Michael S. Tsirkin
2015-12-31 19:08 ` [PATCH v2 18/32] blackfin: " Michael S. Tsirkin
2015-12-31 19:08 ` [PATCH v2 19/32] ia64: " Michael S. Tsirkin
2015-12-31 19:08 ` [PATCH v2 20/32] metag: " Michael S. Tsirkin
2015-12-31 19:08 ` [PATCH v2 21/32] mips: " Michael S. Tsirkin
2015-12-31 19:08 ` [PATCH v2 22/32] s390: " Michael S. Tsirkin
2015-12-31 19:08 ` [PATCH v2 23/32] sh: define __smp_xxx, fix smp_store_mb for !SMP Michael S. Tsirkin
2015-12-31 19:08 ` [PATCH v2 24/32] sparc: define __smp_xxx Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 25/32] tile: " Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 26/32] xtensa: " Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 27/32] x86: " Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 28/32] asm-generic: implement virt_xxx memory barriers Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 29/32] Revert "virtio_ring: Update weak barriers to use dma_wmb/rmb" Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 30/32] virtio_ring: update weak barriers to use __smp_XXX Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 31/32] sh: support a 2-byte smp_store_mb Michael S. Tsirkin
2015-12-31 19:09 ` [PATCH v2 32/32] virtio_ring: use virt_store_mb Michael S. Tsirkin
2015-12-31 19:10 ` [PATCH v2 33/34] xenbus: use virt_xxx barriers Michael S. Tsirkin
2015-12-31 19:10 ` [PATCH v2 34/34] xen/io: " Michael S. Tsirkin
[not found] ` <1451572003-2440-8-git-send-email-mst@redhat.com>
2015-12-31 19:43 ` [PATCH v2 07/32] sparc: reuse asm-generic/barrier.h David Miller
[not found] ` <1451572003-2440-25-git-send-email-mst@redhat.com>
2015-12-31 19:44 ` [PATCH v2 24/32] sparc: define __smp_xxx David Miller
2016-01-01 9:39 ` [PATCH v2 30/32] virtio_ring: update weak barriers to use __smp_xxx Michael S. Tsirkin
[not found] ` <1451572003-2440-31-git-send-email-mst@redhat.com>
2016-01-01 10:21 ` Michael S. Tsirkin
[not found] ` <1451572003-2440-33-git-send-email-mst@redhat.com>
2016-01-01 17:23 ` [PATCH v2 32/32] virtio_ring: use virt_store_mb Sergei Shtylyov
2016-01-03 9:01 ` Michael S. Tsirkin
[not found] ` <1451572003-2440-9-git-send-email-mst@redhat.com>
2016-01-02 11:20 ` [PATCH v2 08/32] arm: reuse asm-generic/barrier.h Russell King - ARM Linux
[not found] ` <1451572003-2440-18-git-send-email-mst@redhat.com>
2016-01-02 11:24 ` [PATCH v2 17/32] arm: define __smp_xxx Russell King - ARM Linux
[not found] ` <20160102112438.GU8644@n2100.arm.linux.org.uk>
2016-01-03 9:12 ` Michael S. Tsirkin
2016-01-04 13:36 ` Peter Zijlstra
[not found] ` <20160104133658.GY6344@twins.programming.kicks-ass.net>
2016-01-04 13:54 ` Peter Zijlstra
2016-01-04 13:59 ` Russell King - ARM Linux
2016-01-04 20:39 ` Michael S. Tsirkin
[not found] ` <20160104135934.GE19062@n2100.arm.linux.org.uk>
2016-01-05 14:38 ` Michael S. Tsirkin
2016-01-04 20:12 ` Michael S. Tsirkin
[not found] ` <1451572003-2440-34-git-send-email-mst@redhat.com>
2016-01-04 11:32 ` [Xen-devel] [PATCH v2 33/34] xenbus: use virt_xxx barriers David Vrabel
2016-01-04 12:03 ` Stefano Stabellini
2016-01-04 14:09 ` Peter Zijlstra
[not found] ` <1451572003-2440-35-git-send-email-mst@redhat.com>
2016-01-04 11:32 ` [Xen-devel] [PATCH v2 34/34] xen/io: " David Vrabel
2016-01-04 12:05 ` Stefano Stabellini
[not found] ` <1451572003-2440-7-git-send-email-mst@redhat.com>
2016-01-04 13:20 ` [PATCH v2 06/32] s390: reuse asm-generic/barrier.h Peter Zijlstra
2016-01-04 15:03 ` Martin Schwidefsky
2016-01-04 20:42 ` Michael S. Tsirkin
[not found] ` <20160104224135-mutt-send-email-mst@redhat.com>
2016-01-05 8:03 ` Martin Schwidefsky [this message]
2016-01-04 20:34 ` Michael S. Tsirkin
[not found] ` <1451572003-2440-12-git-send-email-mst@redhat.com>
2016-01-04 13:26 ` [PATCH v2 11/32] mips: " Peter Zijlstra
[not found] ` <1451572003-2440-23-git-send-email-mst@redhat.com>
2016-01-04 13:45 ` [PATCH v2 22/32] s390: define __smp_xxx Peter Zijlstra
2016-01-04 20:18 ` Michael S. Tsirkin
[not found] ` <20160104221323-mutt-send-email-mst@redhat.com>
2016-01-05 8:13 ` Martin Schwidefsky
[not found] ` <20160105091319.59ddefc7@mschwide>
2016-01-05 9:30 ` Michael S. Tsirkin
[not found] ` <20160105105335-mutt-send-email-mst@redhat.com>
2016-01-05 12:08 ` Martin Schwidefsky
[not found] ` <20160105130852.11148a7f@mschwide>
2016-01-05 13:04 ` Michael S. Tsirkin
[not found] ` <20160105144842-mutt-send-email-mst@redhat.com>
2016-01-05 14:21 ` Martin Schwidefsky
2016-01-05 15:39 ` Christian Borntraeger
[not found] ` <568BE3B9.8020901@de.ibm.com>
2016-01-05 16:04 ` Michael S. Tsirkin
[not found] ` <1451572003-2440-32-git-send-email-mst@redhat.com>
2016-01-04 14:05 ` [PATCH v2 31/32] sh: support a 2-byte smp_store_mb Peter Zijlstra
[not found] ` <1451572003-2440-11-git-send-email-mst@redhat.com>
2016-01-04 23:24 ` [PATCH v2 10/32] metag: reuse asm-generic/barrier.h James Hogan
[not found] ` <1451572003-2440-21-git-send-email-mst@redhat.com>
2016-01-04 13:41 ` [PATCH v2 20/32] metag: define __smp_xxx Peter Zijlstra
2016-01-04 15:25 ` James Hogan
[not found] ` <20160104152558.GD17861@jhogan-linux.le.imgtec.org>
2016-01-04 15:30 ` Peter Zijlstra
2016-01-04 16:04 ` James Hogan
2016-01-05 0:09 ` James Hogan
[not found] ` <20160105000929.GM17861@jhogan-linux.le.imgtec.org>
2016-01-11 11:10 ` Michael S. Tsirkin
[not found] ` <1451572003-2440-16-git-send-email-mst@redhat.com>
2016-01-05 1:36 ` [PATCH v2 15/32] powerpc: " Boqun Feng
[not found] ` <20160105013648.GA1256@fixme-laptop.cn.ibm.com>
2016-01-05 8:51 ` Michael S. Tsirkin
[not found] ` <20160105085117.GA11858@redhat.com>
2016-01-05 9:53 ` Boqun Feng
[not found] ` <20160105095341.GA5321@fixme-laptop.cn.ibm.com>
2016-01-05 16:16 ` Michael S. Tsirkin
[not found] ` <20160105180938-mutt-send-email-mst@redhat.com>
2016-01-06 1:51 ` Boqun Feng
[not found] ` <20160106015152.GA14605@fixme-laptop.cn.ibm.com>
2016-01-06 20:23 ` Michael S. Tsirkin
[not found] ` <20160106222337-mutt-send-email-mst@redhat.com>
2016-01-07 0:43 ` Boqun Feng
[not found] ` <1451572003-2440-13-git-send-email-mst@redhat.com>
2016-01-05 23:12 ` [PATCH v2 12/32] x86/um: reuse asm-generic/barrier.h Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105090301.3f9939be@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=dave@stgolabs.net \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=mst@redhat.com \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).