From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Igor Redko <redkoi@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics
Date: Tue, 23 Feb 2016 17:53:27 +0200 [thread overview]
Message-ID: <20160223174952-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <56CC7A37.2030807@openvz.org>
On Tue, Feb 23, 2016 at 06:26:47PM +0300, Denis V. Lunev wrote:
> On 02/23/2016 06:10 PM, Michael S. Tsirkin wrote:
> >On Tue, Feb 16, 2016 at 06:50:52PM +0300, Denis V. Lunev wrote:
> >>From: Igor Redko <redkoi@virtuozzo.com>
> >>
> >>Add a new field, VIRTIO_BALLOON_S_AVAIL, to virtio_balloon memory
> >>statistics protocol, corresponding to 'Available' in /proc/meminfo.
> >>
> >>It indicates to the hypervisor how big the balloon can be inflated
> >>without pushing the guest system to swap.
> >>
> >>Signed-off-by: Igor Redko <redkoi@virtuozzo.com>
> >>Reviewed-by: Roman Kagan <rkagan@virtuozzo.com>
> >>Signed-off-by: Denis V. Lunev <den@openvz.org>
> >>CC: Michael S. Tsirkin <mst@redhat.com>
> >>CC: Andrew Morton <akpm@linux-foundation.org>
> >Oops - I missed the fact that this affects host/guest ABI.
> >
> >Can you please submit ABI update proposal to virtio tc?
> >Spec patch would be even better.
> >
> >This is important to ensure there are no conflicts
> >with other features being developed in parallel.
>
> hmmm
>
> From my point of view ABI remains untouched.
Anything exposed by guest to host is ABI.
Once we add stuff there, we never can remove it
as some host might rely on it.
> The guest can send any amount of <tag>;<value>
> pairs and unknown tags are properly ignored
> by the host.
>
> That is why I think that this change is safe.
What happens if someone uses the tag you
used for VIRTIO_BALLOON_S_AVAIL, for some
other purpose?
Any tools using VIRTIO_BALLOON_S_AVAIL will be confused.
Really, it's not hard to get a tag number from virtio TC,
so please just do this.
--
MST
next prev parent reply other threads:[~2016-02-23 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1455637852-7323-1-git-send-email-den@openvz.org>
2016-02-16 15:50 ` [PATCH 1/2] calculate 'available' memory in the separate function Denis V. Lunev
2016-02-16 15:50 ` [PATCH 2/2] virtio_balloon: export 'available' memory to balloon statistics Denis V. Lunev
[not found] ` <1455637852-7323-3-git-send-email-den@openvz.org>
2016-02-23 15:10 ` Michael S. Tsirkin
[not found] ` <20160223170828-mutt-send-email-mst@redhat.com>
2016-02-23 15:26 ` Denis V. Lunev
[not found] ` <56CC7A37.2030807@openvz.org>
2016-02-23 15:53 ` Michael S. Tsirkin [this message]
2016-02-23 16:12 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223174952-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=den@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=redkoi@virtuozzo.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).