From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio: fix "warning: ‘queue’ may be used uninitialized"
Date: Tue, 5 Apr 2016 11:04:10 +0300 [thread overview]
Message-ID: <20160405110113-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <5702AEFB.5090701@suse.com>
On Mon, Apr 04, 2016 at 02:14:19PM -0400, Jeff Mahoney wrote:
> This fixes the following warning:
> drivers/virtio/virtio_ring.c:1032:5: warning: ‘queue’ may be used
> uninitialized in this function
>
> The conditions that govern when queue is set aren't apparent to gcc.
>
> Setting queue = NULL clears the warning.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Which gcc version produces this warning?
I do not seem to see it with gcc 5.3.1.
Also - use uninitialized_var then?
> ---
>
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1006,7 +1006,7 @@ struct virtqueue *vring_create_virtqueue
> const char *name)
> {
> struct virtqueue *vq;
> - void *queue;
> + void *queue = NULL;
> dma_addr_t dma_addr;
> size_t queue_size_in_bytes;
> struct vring vring;
>
> --
> Jeff Mahoney
> SUSE Labs
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2016-04-05 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 18:14 [PATCH] virtio: fix "warning: ‘queue’ may be used uninitialized" Jeff Mahoney
2016-04-05 8:04 ` Michael S. Tsirkin [this message]
2016-04-05 13:34 ` Jeff Mahoney
2016-04-05 14:00 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405110113-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=jeffm@suse.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox