From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Amit Shah <amit.shah@redhat.com>,
Network Development <netdev@vger.kernel.org>,
Alex Williamson <alex.williamson@hp.com>,
Linux Virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: DMA from stack in virtio_net and virtio_console
Date: Sun, 26 Jun 2016 05:06:19 +0300 [thread overview]
Message-ID: <20160626050604-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CALCETrXLQ7ajLaB4FENsg8XmRtjko10BqXR+KNcL7vuVeDrS8w@mail.gmail.com>
On Fri, Jun 24, 2016 at 06:45:50PM -0700, Andy Lutomirski wrote:
> virtio_net does DMA on the stack when it calls sg_init_one in
> virtio_set_queues, virtnet_vlan_rx_add_vid, and
> virtnet_vlan_rx_kill_vid. Michael, I think these are examples we
> missed somehow when fixing these issues earlier on.
>
> virtio_console does it here:
>
> sg_init_one(sg, &cpkt, sizeof(cpkt));
>
> This will cause problems on some architectures (Xen at the very least,
> and it'll cause more subtle problems on other architectures if they
> start using the DMA API), and it will blow up horribly with virtually
> mapped stacks.
>
> Could you fix these, please?
>
> Thanks,
> Andy
Will do, thanks for the report.
--
MST
prev parent reply other threads:[~2016-06-26 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 1:45 DMA from stack in virtio_net and virtio_console Andy Lutomirski
2016-06-26 2:06 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626050604-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@hp.com \
--cc=amit.shah@redhat.com \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).