From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
"Ed L. Cashin" <ed.cashin@acm.org>,
Keith Busch <keith.busch@intel.com>,
Minchan Kim <minchan@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
David Woodhouse <dwmw2@infradead.org>,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 11/15] zram: Pass attribute group to device_add_disk
Date: Thu, 18 Aug 2016 11:06:37 +0900 [thread overview]
Message-ID: <20160818020637.GA500@swordfish> (raw)
In-Reply-To: <20160818015901.GA499@swordfish>
On (08/18/16 10:59), Sergey Senozhatsky wrote:
[..]
> I like the previous "Error creating sysfs group for device" string better,
> than "Error creating disk", because the latter one is much less informative.
>
> do you want to do something like below?
>
> int device_add_disk(struct device *parent, struct gendisk *disk,
> ...
> if (attr_group) {
> retval = sysfs_create_group(&disk_to_dev(disk)->kobj,
> attr_group);
>
> + pr_err("Error creating sysfs group for device ...\n", ...);
d'oh... a typo. pr_err() is meant to be in `if (retval)' branch.
> if (retval)
> goto fail;
> }
-ss
next prev parent reply other threads:[~2016-08-18 2:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1471418115-3654-1-git-send-email-famz@redhat.com>
2016-08-17 7:15 ` [PATCH 01/15] disk: Drop add_disk in favor of device_add_disk Fam Zheng
2016-08-17 7:15 ` [PATCH 02/15] genhd: Return error from register_disk() Fam Zheng
2016-08-17 7:15 ` [PATCH 03/15] genhd: Return error from blk_register_region Fam Zheng
2016-08-17 7:15 ` [PATCH 04/15] block: Return error from blk_integrity_add Fam Zheng
2016-08-17 7:15 ` [PATCH 05/15] genhd: Return error from disk_{add,alloc}_events Fam Zheng
2016-08-17 7:15 ` [PATCH 06/15] genhd: Add return code to device_add_disk Fam Zheng
[not found] ` <20160817104914.37087cb3.cornelia.huck@de.ibm.com>
2016-08-17 8:48 ` Fam Zheng
2016-08-17 9:06 ` Cornelia Huck
[not found] ` <20160817110645.45370f57.cornelia.huck@de.ibm.com>
2016-08-17 9:14 ` Fam Zheng
[not found] ` <20160817091422.GE19326@al.usersys.redhat.com>
2016-08-18 1:09 ` Ed Cashin
2016-08-17 8:49 ` Cornelia Huck
2016-08-17 7:15 ` [PATCH 07/15] genhd: Add attribute group parameter " Fam Zheng
2016-08-17 7:15 ` [PATCH 08/15] nvme: Pass attribute group " Fam Zheng
2016-08-17 8:13 ` kbuild test robot
2016-08-17 7:15 ` [PATCH 09/15] virtio-blk: " Fam Zheng
2016-09-04 4:18 ` Michael S. Tsirkin
2016-08-17 7:15 ` [PATCH 10/15] mtd: " Fam Zheng
2016-08-17 7:15 ` [PATCH 11/15] zram: " Fam Zheng
2016-08-18 1:59 ` Sergey Senozhatsky
[not found] ` <20160818015901.GA499@swordfish>
2016-08-18 2:06 ` Sergey Senozhatsky [this message]
2016-08-17 7:15 ` [PATCH 12/15] mtip: " Fam Zheng
2016-08-17 7:15 ` [PATCH 13/15] aoeblk: " Fam Zheng
2016-08-17 7:15 ` [PATCH 14/15] axonram: " Fam Zheng
2016-08-17 7:15 ` [PATCH 15/15] block: Add FIXME comment to handle device_add_disk error Fam Zheng
[not found] ` <1471418115-3654-16-git-send-email-famz@redhat.com>
2016-08-18 2:36 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818020637.GA500@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ed.cashin@acm.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=ngupta@vflare.org \
--cc=paulus@samba.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).