From: Amit Shah <amit.shah@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: x86@kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_console: Stop doing DMA on the stack
Date: Tue, 6 Sep 2016 12:33:43 +0530 [thread overview]
Message-ID: <20160906070343.GD3100@amit-lp.rh> (raw)
In-Reply-To: <0afe68f9b4be6c95af9e7672b07acd0274c26dfe.1472569320.git.luto@kernel.org>
On (Tue) 30 Aug 2016 [08:04:15], Andy Lutomirski wrote:
> virtio_console uses a small DMA buffer for control requests. Move
> that buffer into heap memory.
>
> Doing virtio DMA on the stack is normally okay on non-DMA-API virtio
> systems (which is currently most of them), but it breaks completely
> if the stack is virtually mapped.
>
> Tested by typing both directions using picocom aimed at /dev/hvc0.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Looks fine,
Reviewed-by: Amit Shah <amit.shah@redhat.com>
> ---
>
> Hi all-
>
> This is currently broken in tip:x86/asm. If you (Amit) like this patch,
> would it make sense for Ingo to add it to -tip?
Yes, I'm fine with that.
Amit
next prev parent reply other threads:[~2016-09-06 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 15:04 [PATCH] virtio_console: Stop doing DMA on the stack Andy Lutomirski
2016-09-06 7:03 ` Amit Shah [this message]
2016-09-08 6:49 ` Ingo Molnar
[not found] ` <20160908064943.GA25876@gmail.com>
2016-09-09 18:10 ` Michael S. Tsirkin
2016-09-10 4:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906070343.GD3100@amit-lp.rh \
--to=amit.shah@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).