From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: kernellwp@gmail.com, linux-s390@vger.kernel.org,
benh@kernel.crashing.org, jgross@suse.com, kvm@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, mingo@redhat.com,
paulus@samba.org, mpe@ellerman.id.au,
xen-devel-request@lists.xenproject.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
pbonzini@redhat.com, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH v2 1/1] s390/spinlock: Provide vcpu_is_preempted
Date: Wed, 19 Oct 2016 09:44:48 +0200 [thread overview]
Message-ID: <20161019074448.GC4077@osiris> (raw)
In-Reply-To: <190cd825-ca7c-d160-a0ac-4e0d27ac4a93@de.ibm.com>
On Wed, Oct 19, 2016 at 08:56:36AM +0200, Christian Borntraeger wrote:
> On 09/29/2016 05:51 PM, Christian Borntraeger wrote:
> > this implements the s390 backend for commit
> > "kernel/sched: introduce vcpu preempted check interface"
> > by reworking the existing smp_vcpu_scheduled into
> > arch_vcpu_is_preempted. We can then also get rid of the
> > local cpu_is_preempted function by moving the
> > CIF_ENABLED_WAIT test into arch_vcpu_is_preempted.
> >
> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
>
> Martin, Peter,
>
> I think we could go with the patch as is. In other words not providing
> arch_vcpu_is_preempted for !CONFIG_SMP.
>
> This will result in compile errors if code does spinning or yielding for
> non-SMP kernels - which does not make sense to me, so this might actually
> be a nice indicator.
> If you prefer the !CONFIG_SMP implementation let me know and I will respin.
...but I do prefer an implementation for !CONFIG_SMP. I'm tired of fixing
silly compile errors that only happen on s390.
next prev parent reply other threads:[~2016-10-19 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1475164265-246160-1-git-send-email-borntraeger@de.ibm.com>
2016-09-29 15:51 ` [PATCH v2 1/1] s390/spinlock: Provide vcpu_is_preempted Christian Borntraeger
[not found] ` <1475164265-246160-2-git-send-email-borntraeger@de.ibm.com>
2016-09-30 4:49 ` Pan Xinhui
2016-09-30 5:52 ` Boqun Feng
2016-09-30 6:35 ` Pan Xinhui
2016-10-04 10:17 ` Christian Borntraeger
2016-09-30 10:29 ` Christian Borntraeger
2016-10-19 6:56 ` Christian Borntraeger
[not found] ` <190cd825-ca7c-d160-a0ac-4e0d27ac4a93@de.ibm.com>
2016-10-19 7:44 ` Heiko Carstens [this message]
2016-10-19 8:42 ` [PATCH v3] " Christian Borntraeger
2016-10-19 8:50 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019074448.GC4077@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=jgross@suse.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=xen-devel-request@lists.xenproject.org \
--cc=xinhui.pan@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).