From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: "G. Campana" <gcampana@quarkslab.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2] virtio_console: fix a crash in config_work_handler
Date: Mon, 16 Jan 2017 15:30:42 +0200 [thread overview]
Message-ID: <20170116153032-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170116102723.GM16209@amit-lp.rh>
On Mon, Jan 16, 2017 at 03:57:23PM +0530, Amit Shah wrote:
> On (Mon) 16 Jan 2017 [10:45:02], G. Campana wrote:
> > Using control_work instead of config_work as the 3rd argument to
> > container_of results in an invalid portdev pointer. Indeed, the work
> > structure is initialized as below:
> >
> > INIT_WORK(&portdev->config_work, &config_work_handler);
> >
> > It leads to a crash when portdev->vdev is dereferenced later. This bug
> > is triggered when the guest uses a virtio-console without multiport
> > feature and receives a config_changed virtio interrupt.
> >
> > Signed-off-by: G. Campana <gcampana@quarkslab.com>
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> Michael, can you please pick this up?
>
> Amit
Sure.
prev parent reply other threads:[~2017-01-16 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170116033550.GK16209@amit-lp.rh>
2017-01-16 9:45 ` [PATCH v2] virtio_console: fix a crash in config_work_handler G. Campana
[not found] ` <1484559902-5346-1-git-send-email-gcampana@quarkslab.com>
2017-01-16 10:27 ` Amit Shah
[not found] ` <20170116102723.GM16209@amit-lp.rh>
2017-01-16 13:30 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116153032-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=gcampana@quarkslab.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).