virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3] vfio error recovery: kernel support
Date: Mon, 23 Jan 2017 01:01:12 +0200	[thread overview]
Message-ID: <20170123010102-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d7e5bb6f-0af8-442d-c68a-364f6067048d@redhat.com>

On Sun, Jan 22, 2017 at 04:01:28PM +0800, Jason Wang wrote:
> 
> 
> On 2017年01月22日 15:38, Michael S. Tsirkin wrote:
> > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> > index 26c155b..6b0f416 100644
> > --- a/include/linux/virtio_config.h
> > +++ b/include/linux/virtio_config.h
> > @@ -159,7 +159,17 @@ static inline bool virtio_has_iommu_quirk(const struct virtio_device *vdev)
> >   	 * Note the reverse polarity of the quirk feature (compared to most
> >   	 * other features), this is for compatibility with legacy systems.
> >   	 */
> > -	return !virtio_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM);
> > +	if (virtio_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM))
> > +		return false;
> > +
> > +	/*
> > +	 * fastboot emulator for ARM puts virtio devices behind an SMMU
> > +	 * and never bypasses it for legacy devices.
> > +	 */
> > +	if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
> > +		return virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
> > +
> > +	return true;
> >   }
> 
> Hi Michael:
> 
> This part of codes seems unrelated.
> 
> Thanks

Of course it is, thanks!
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

      reply	other threads:[~2017-01-22 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22  7:38 [PATCH v3] vfio error recovery: kernel support Michael S. Tsirkin
2017-01-22  8:01 ` Jason Wang
2017-01-22 23:01   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123010102-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).