From: Amit Shah <amit.shah@redhat.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: kernel-team@fb.com, "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio-console: avoid DMA from stack
Date: Wed, 1 Feb 2017 19:17:12 +0530 [thread overview]
Message-ID: <20170201134712.GA7935@amit-lp.rh> (raw)
In-Reply-To: <075115ddd99246ffc4228a3e050ba68eb36c6a8c.1485935920.git.osandov@fb.com>
On (Wed) 01 Feb 2017 [00:02:27], Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> put_chars() stuffs the buffer it gets into an sg, but that buffer may be
> on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
> manifested as printks getting turned into NUL bytes).
Seems reasonable. I wonder since all implementations of hvc do a
memcpy, if we can abstract it - but that'll need some work.
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Michael, please add to the virtio queue.
Amit
next prev parent reply other threads:[~2017-02-01 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 8:02 [PATCH] virtio-console: avoid DMA from stack Omar Sandoval
2017-02-01 13:47 ` Amit Shah [this message]
2017-03-01 20:01 ` Omar Sandoval
2017-03-01 21:25 ` Michael S. Tsirkin
2017-03-03 0:58 ` Jan Dakinevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201134712.GA7935@amit-lp.rh \
--to=amit.shah@redhat.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=osandov@osandov.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).