virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Ladi Prosek <lprosek@redhat.com>
To: virtualization@lists.linux-foundation.org
Cc: arnd@arndb.de, mst@redhat.com
Subject: [PATCH v3 1/3] virtio_balloon: don't push uninitialized buffers to stats virtqueue
Date: Tue, 28 Mar 2017 18:46:57 +0200	[thread overview]
Message-ID: <20170328164659.4311-2-lprosek@redhat.com> (raw)
In-Reply-To: <20170328164659.4311-1-lprosek@redhat.com>

When init_vqs runs, virtio_balloon.stats is either uninitialized or
contains stale values. The host updates its state with garbage data
because it has no way of knowing that this is just a marker buffer
used for signaling.

This patch updates the stats before pushing the initial buffer.

Signed-off-by: Ladi Prosek <lprosek@redhat.com>
---
 drivers/virtio/virtio_balloon.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 4e11915..fcd06e1 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -429,6 +429,8 @@ static int init_vqs(struct virtio_balloon *vb)
 		 * Prime this virtqueue with one buffer so the hypervisor can
 		 * use it to signal us later (it can't be broken yet!).
 		 */
+		update_balloon_stats(vb);
+
 		sg_init_one(&sg, vb->stats, sizeof vb->stats);
 		if (virtqueue_add_outbuf(vb->stats_vq, &sg, 1, vb, GFP_KERNEL)
 		    < 0)
-- 
2.9.3

  reply	other threads:[~2017-03-28 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-28 16:46 [PATCH v3 0/3] virtio_balloon: don't push uninitialized buffers to stats virtqueue Ladi Prosek
2017-03-28 16:46 ` Ladi Prosek [this message]
2017-03-28 16:46 ` [PATCH v3 2/3] virtio-balloon: use actual number of stats for stats queue buffers Ladi Prosek
2017-03-28 20:33   ` Arnd Bergmann
2017-03-28 16:46 ` [PATCH v3 3/3] virtio_balloon: prevent uninitialized variable use Ladi Prosek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328164659.4311-2-lprosek@redhat.com \
    --to=lprosek@redhat.com \
    --cc=arnd@arndb.de \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).