From: Laurent Vivier <lvivier@redhat.com>
To: dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
virtualization@lists.linux-foundation.org
Subject: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats
Date: Wed, 5 Apr 2017 10:09:15 +0200 [thread overview]
Message-ID: <20170405080915.823-1-lvivier@redhat.com> (raw)
When we use virtio-vga with a big-endian guest,
the mouse pointer disappears.
To fix that, on big-endian use DRM_FORMAT_BGRA8888
instead of DRM_FORMAT_ARGB8888.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index 11288ff..3ed7174 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -39,7 +39,11 @@ static const uint32_t virtio_gpu_formats[] = {
};
static const uint32_t virtio_gpu_cursor_formats[] = {
+#ifdef __BIG_ENDIAN
+ DRM_FORMAT_BGRA8888,
+#else
DRM_FORMAT_ARGB8888,
+#endif
};
static void virtio_gpu_plane_destroy(struct drm_plane *plane)
--
2.9.3
next reply other threads:[~2017-04-05 8:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 8:09 Laurent Vivier [this message]
2017-04-05 17:11 ` [PATCH] drm: virtio: fix virtio_gpu_cursor_formats Ville Syrjälä
[not found] ` <20170405171125.GT30290@intel.com>
2017-04-06 7:20 ` Laurent Vivier
2017-04-06 8:25 ` Daniel Vetter
2017-04-06 8:29 ` DRM_FORMAT_* byte order (was: Re: [PATCH] drm: virtio: fix virtio_gpu_cursor_formats) Gerd Hoffmann
2017-04-06 17:27 ` Ville Syrjälä
2017-04-06 17:35 ` Ville Syrjälä
2017-04-07 8:13 ` Gerd Hoffmann
[not found] ` <20170406173514.GC30290@intel.com>
2017-04-07 8:29 ` Gerd Hoffmann
[not found] ` <1491553740.26308.26.camel@redhat.com>
2017-04-07 8:45 ` Ville Syrjälä
2017-04-07 10:06 ` Gerd Hoffmann
[not found] ` <1491559586.26308.39.camel@redhat.com>
2017-04-07 12:49 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405080915.823-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox