Linux virtualization list
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "bfields@fieldses.org" <bfields@fieldses.org>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	virtualization@lists.linux-foundation.org,
	"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
	Trond Myklebust <trondmy@primarydata.com>,
	"jlayton@poochiereds.net" <jlayton@poochiereds.net>,
	hch <hch@lst.de>
Subject: Re: remove function pointer casts and constify function tables
Date: Tue, 30 May 2017 19:26:37 +0300	[thread overview]
Message-ID: <20170530192544-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170526193133.GA9874@fieldses.org>

On Fri, May 26, 2017 at 03:31:33PM -0400, bfields@fieldses.org wrote:
> Looks like the culprit is very likely d85b758f72b0 "virtio_net: fix
> support for small rings".
> 
> After that patch, my NFS server VM stops responding to packets after a
> few minutes of testing.  Before that patch, my server keeps working.
> 
> --b.

Others complained about that too.
I'm still trying to reproduce though.

Meanwhile, could you please locate this line of code:
+               vi->rq[i].min_buf_len = mergeable_min_buf_len(vi, vi->rq[i].vq);

and add something like
        printk(KERN_ERR, "min buf = 0x%x expected 0x%x size 0x%x big %d\n",
               vi->rq[i].min_buf_len, GOOD_PACKET_LEN,
               virtqueue_get_vring_size(vi->rq[i].vq),
               (int)vi->big_packets);

after it?
Then boot and capture the output.

Thanks!


-- 
MST

  parent reply	other threads:[~2017-05-30 16:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170512161701.22468-1-hch@lst.de>
     [not found] ` <1494620040.19467.1.camel@primarydata.com>
     [not found]   ` <20170513072557.GA14602@lst.de>
     [not found]     ` <1494691819.31377.1.camel@primarydata.com>
     [not found]       ` <20170515152134.GC24547@fieldses.org>
     [not found]         ` <20170515154450.GA18630@lst.de>
     [not found]           ` <20170523081159.GA19216@lst.de>
     [not found]             ` <20170523122334.GA4298@fieldses.org>
     [not found]               ` <20170526150839.GA4593@fieldses.org>
2017-05-26 15:09                 ` remove function pointer casts and constify function tables bfields
     [not found]                 ` <20170526150956.GB4593@fieldses.org>
2017-05-26 19:31                   ` bfields
     [not found]                   ` <20170526193133.GA9874@fieldses.org>
2017-05-30 16:26                     ` Michael S. Tsirkin [this message]
2017-05-30 16:58                       ` Michael S. Tsirkin
     [not found]                       ` <20170530195716-mutt-send-email-mst@kernel.org>
2017-05-31 20:57                         ` bfields
2017-05-31 21:09                       ` bfields
     [not found]                       ` <20170531210923.GF23526@fieldses.org>
2017-05-31 21:15                         ` bfields
2017-05-30 17:03                     ` Michael S. Tsirkin
     [not found]                     ` <20170530200109-mutt-send-email-mst@kernel.org>
2017-05-31 21:00                       ` bfields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530192544-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=hch@lst.de \
    --cc=jlayton@poochiereds.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@primarydata.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox