From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP
Date: Wed, 28 Jun 2017 05:02:46 +0300 [thread overview]
Message-ID: <20170628050057-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1498614843-8163-1-git-send-email-jasowang@redhat.com>
On Wed, Jun 28, 2017 at 09:54:03AM +0800, Jason Wang wrote:
> We should allow csumed packet for small buffer, otherwise XDP_PASS
> won't work correctly.
>
> Fixes commit bb91accf2733 ("virtio-net: XDP support for small buffers")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
The issue would be VIRTIO_NET_HDR_F_DATA_VALID might be set.
What do you think?
> ---
> The patch is needed for -stable.
> ---
> drivers/net/virtio_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 143d8a9..499fcc9 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -413,7 +413,7 @@ static struct sk_buff *receive_small(struct net_device *dev,
> void *orig_data;
> u32 act;
>
> - if (unlikely(hdr->hdr.gso_type || hdr->hdr.flags))
> + if (unlikely(hdr->hdr.gso_type))
> goto err_xdp;
>
> xdp.data_hard_start = buf + VIRTNET_RX_PAD + vi->hdr_len;
> --
> 2.7.4
next prev parent reply other threads:[~2017-06-28 2:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 1:54 [PATCH net] virtio-net: unbreak cusmed packet for small buffer XDP Jason Wang
2017-06-28 2:02 ` Michael S. Tsirkin [this message]
2017-06-28 2:14 ` Jason Wang
2017-06-28 2:17 ` Michael S. Tsirkin
2017-06-28 2:45 ` Jason Wang
2017-06-28 3:31 ` Michael S. Tsirkin
2017-06-28 3:40 ` Jason Wang
2017-06-28 4:01 ` Michael S. Tsirkin
2017-06-28 12:05 ` Jason Wang
2017-07-03 17:03 ` Michael S. Tsirkin
[not found] ` <20170703195752-mutt-send-email-mst@kernel.org>
2017-07-04 12:20 ` Jason Wang
2017-07-06 0:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170628050057-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).