From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Liu, Changpeng" <changpeng.liu@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "hch@lst.de" <hch@lst.de>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver
Date: Wed, 5 Jul 2017 15:56:00 +0300 [thread overview]
Message-ID: <20170705155404-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <FF7FC980937D6342B9D289F5F3C7C2625B595B29@SHSMSX103.ccr.corp.intel.com>
On Wed, Jul 05, 2017 at 07:57:07AM +0000, Liu, Changpeng wrote:
>
>
> > -----Original Message-----
> > From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> > Sent: Tuesday, July 4, 2017 5:24 PM
> > To: Liu, Changpeng <changpeng.liu@intel.com>; virtualization@lists.linux-
> > foundation.org
> > Cc: stefanha@gmail.com; hch@lst.de; mst@redhat.com
> > Subject: Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver
> >
> >
> >
> > On 05/07/2017 10:44, Changpeng Liu wrote:
> > > Currently virtio-blk driver does not provide discard feature flag, so the
> > > filesystems which built on top of the block device will not send discard
> > > command. This is okay for HDD backend, but it will impact the performance
> > > for SSD backend.
> > >
> > > Add a feature flag VIRTIO_BLK_F_DISCARD and command
> > VIRTIO_BLK_T_DISCARD
> > > to extend exist virtio-blk protocol, define 16 bytes discard descriptor
> > > for each discard segment, the discard segment defination aligns with
> > > SCSI or NVM Express protocols, virtio-blk driver will support multi-range
> > > discard request as well.
> > >
> > > Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
> >
> > Please include a patch for the specification. Since we are at it, I
> Thanks Paolo, do you mean include a text file which describe the changes for the specification?
Paolo answered that. But please also CC code patch to virtio-comment@lists.oasis-open.org
.
This is a subscriber-only list so pls subscribe beforehand:
https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio#feedback
--
MST
prev parent reply other threads:[~2017-07-05 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 8:26 [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver Changpeng Liu
2017-07-04 9:24 ` Paolo Bonzini
2017-07-04 21:35 ` Michael S. Tsirkin
2017-07-05 7:57 ` Liu, Changpeng
2017-07-05 8:00 ` Paolo Bonzini
2017-07-05 12:56 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705155404-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=changpeng.liu@intel.com \
--cc=hch@lst.de \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).