From: Koichiro Den <den@klaipeden.com>
To: mst@redhat.com
Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi
Date: Sat, 19 Aug 2017 15:38:54 +0900 [thread overview]
Message-ID: <20170819063854.27010-1-den@klaipeden.com> (raw)
Facing the possible unbounded delay relying on freeing on xmit path,
we also better to invoke and clear the upper layer zerocopy callback
beforehand to keep them from waiting for unbounded duration in vain.
For instance, this removes the possible deadlock in the case that the
upper layer is a zerocopy-enabled vhost-net.
This does not apply if napi_tx is enabled since it will be called in
reasonale time.
Signed-off-by: Koichiro Den <den@klaipeden.com>
---
drivers/net/virtio_net.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 4302f313d9a7..f7deaa5b7b50 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1290,6 +1290,14 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)
/* Don't wait up for transmitted skbs to be freed. */
if (!use_napi) {
+ if (skb_shinfo(skb)->tx_flags & SKBTX_DEV_ZEROCOPY) {
+ struct ubuf_info *uarg;
+ uarg = skb_shinfo(skb)->destructor_arg;
+ if (uarg->callback)
+ uarg->callback(uarg, true);
+ skb_shinfo(skb)->destructor_arg = NULL;
+ skb_shinfo(skb)->tx_flags &= ~SKBTX_DEV_ZEROCOPY;
+ }
skb_orphan(skb);
nf_reset(skb);
}
--
2.9.4
next reply other threads:[~2017-08-19 6:38 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 6:38 Koichiro Den [this message]
2017-08-20 20:49 ` [PATCH net-next] virtio-net: invoke zerocopy callback on xmit path if no tx napi Willem de Bruijn
2017-08-21 12:40 ` Koichiro Den
2017-08-22 12:11 ` Willem de Bruijn
[not found] ` <CAF=yD-LO0rP1A_hrxqx_1HYEv6qyk=Sc=D7iH7cPh2YXDm=cYQ@mail.gmail.com>
2017-08-22 14:04 ` Koichiro Den
[not found] ` <1503410668.8694.14.camel@klaipeden.com>
2017-08-22 17:19 ` Willem de Bruijn
[not found] ` <CAF=yD-JyLEUgUgeH5TjRUj2wz9CjRkAx1HUyXRxCDyT5iHx-sg@mail.gmail.com>
2017-08-23 14:26 ` Koichiro Den
2017-08-21 12:33 ` Jason Wang
[not found] ` <5352c98a-fa48-fcf9-c062-9986a317a1b0@redhat.com>
2017-08-21 12:58 ` Koichiro Den
2017-08-21 15:41 ` Willem de Bruijn
[not found] ` <CAF=yD-LZ4=WAYfUtY7xRWi50FRSkrcOa+b7uc46xRnC4sbDCzQ@mail.gmail.com>
2017-08-22 2:50 ` Jason Wang
[not found] ` <64d451ae-9944-e978-5a05-54bb1a62aaad@redhat.com>
2017-08-22 3:10 ` Willem de Bruijn
[not found] ` <CAF=yD-L-9QnxV2kM_j2BxVk=h7i3wvMZxG-3_=0Q=jDPgeT=VQ@mail.gmail.com>
2017-08-22 11:47 ` Jason Wang
2017-08-22 13:42 ` Koichiro Den
2017-08-22 17:16 ` Willem de Bruijn
[not found] ` <CAF=yD-+AOnYafiwAf+v+fhyg_0fi-6LdQSnPYcoAcngJqYs9dg@mail.gmail.com>
2017-08-23 14:24 ` Koichiro Den
2017-08-22 17:55 ` Michael S. Tsirkin
[not found] ` <20170822204015-mutt-send-email-mst@kernel.org>
2017-08-22 18:01 ` David Miller
[not found] ` <20170822.110108.343109469263087166.davem@davemloft.net>
2017-08-22 18:28 ` Eric Dumazet
2017-08-22 18:39 ` Michael S. Tsirkin
2017-08-23 14:28 ` Koichiro Den
[not found] ` <1503498504.8694.26.camel@klaipeden.com>
2017-08-23 14:47 ` Koichiro Den
2017-08-23 15:20 ` Willem de Bruijn
[not found] ` <CAF=yD-+U_aWxSmPPY8v8t=JO0MRZ+N+DzVJTAMKYQ5F=pE1PfA@mail.gmail.com>
2017-08-23 22:57 ` Michael S. Tsirkin
[not found] ` <20170824014553-mutt-send-email-mst@kernel.org>
2017-08-24 3:28 ` Willem de Bruijn
[not found] ` <CAF=yD-KSek+LmZu0X0TXetmFEQ59iF3NpjZ4KugbwLo1BGfhaA@mail.gmail.com>
2017-08-24 4:34 ` Michael S. Tsirkin
2017-08-24 13:50 ` Michael S. Tsirkin
2017-08-24 20:20 ` Willem de Bruijn
[not found] ` <CAF=yD-+9Ah8pC9i2w3Ad3WnhQit7Yo479pMrToty7priL6BFLw@mail.gmail.com>
2017-08-24 20:50 ` Michael S. Tsirkin
[not found] ` <20170824234551-mutt-send-email-mst@kernel.org>
2017-08-25 22:44 ` Willem de Bruijn
[not found] ` <CAF=yD-+1wheMmC+HFKe_B_ULO0Mmh6HMSEbYY5D-HgqxVJee6A@mail.gmail.com>
2017-08-25 23:32 ` Michael S. Tsirkin
[not found] ` <20170826022744-mutt-send-email-mst@kernel.org>
2017-08-26 1:03 ` Willem de Bruijn
[not found] ` <CAF=yD-Lre0NATUVH8p0zS=G5CiY=WfKSefLmOZw940jZFgECgQ@mail.gmail.com>
2017-08-29 19:35 ` Willem de Bruijn
2017-08-29 19:42 ` Michael S. Tsirkin
[not found] ` <20170829224136-mutt-send-email-mst@kernel.org>
2017-08-29 19:53 ` Willem de Bruijn
[not found] ` <CAF=yD-L5MG5RCZzT8EZ0coFiuQLp-2UQN0zzQefVnEd7rMQbyw@mail.gmail.com>
2017-08-29 20:40 ` Michael S. Tsirkin
[not found] ` <20170829233920-mutt-send-email-mst@kernel.org>
2017-08-29 22:55 ` Willem de Bruijn
2017-08-30 1:45 ` Jason Wang
[not found] ` <b8893b72-4d09-2492-0d31-5135286e6874@redhat.com>
2017-08-30 3:11 ` Willem de Bruijn
[not found] ` <CAF=yD-KUoW6hxZtpAmyVrJXCY+=Fq1FOcbD3h=HmDQaPoC1MLg@mail.gmail.com>
2017-09-01 3:08 ` Jason Wang
2017-08-31 14:30 ` Willem de Bruijn
[not found] ` <CAF=yD-+AjQLLUKdvnrwd2tqFtw4Hm81cR7WUJd65oLnziNGM8A@mail.gmail.com>
2017-09-01 3:25 ` Jason Wang
[not found] ` <5ef7fcf3-d4f0-be16-6ddb-724d954cfc68@redhat.com>
2017-09-01 16:15 ` Willem de Bruijn
[not found] ` <CAF=yD-JREJqpsRdCi31qo1QNFEE2DDCaTGYw1f1waPgtov8WEg@mail.gmail.com>
2017-09-01 16:17 ` Willem de Bruijn
[not found] ` <CAF=yD-LZ4Abn8CFSQyuNnYSRZkHx4FTzK4hSi9WQaHO-28rsHQ@mail.gmail.com>
2017-09-04 3:03 ` Jason Wang
[not found] ` <96819b6a-6d44-fd7e-37af-5a0db81b3840@redhat.com>
2017-09-05 14:09 ` Willem de Bruijn
2017-09-06 3:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170819063854.27010-1-den@klaipeden.com \
--to=den@klaipeden.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox