From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
weiping zhang <zhangweiping@didichuxing.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/3] virtio_pci: use put_device instead of kfree
Date: Fri, 15 Dec 2017 13:32:56 +0100 [thread overview]
Message-ID: <20171215133256.4262ac9d.cohuck@redhat.com> (raw)
In-Reply-To: <20171215034700-mutt-send-email-mst@kernel.org>
On Fri, 15 Dec 2017 03:48:09 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Also just to make sure, none of this is a regression and none
> of this causes actual known issues right?
>
> I think it's preferrable to defer to next merge cycle unless this
> is a regression.
I noticed this while looking at the cleanup path for
regsiter_virtio_device(), I don't think any actual problems have been
seen in the wild (just a latent bug). Deferring to the next merge
window seems reasonable.
next prev parent reply other threads:[~2017-12-15 12:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 13:13 [PATCH v2 0/3] fix cleanup for fail to register_virtio_device weiping zhang
2017-12-12 13:24 ` [PATCH v2 1/3] virtio_pci: use put_device instead of kfree weiping zhang
2017-12-14 19:13 ` Michael S. Tsirkin
2017-12-15 1:38 ` weiping zhang
2017-12-15 1:48 ` Michael S. Tsirkin
2017-12-15 12:32 ` Cornelia Huck [this message]
2017-12-15 12:21 ` Cornelia Huck
2017-12-16 22:13 ` Michael S. Tsirkin
2017-12-12 13:24 ` [PATCH v2 2/3] virtio: " weiping zhang
2017-12-13 8:27 ` Cornelia Huck
2017-12-12 13:25 ` [PATCH v2 3/3] virtio: put reference count of virtio_device.dev weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215133256.4262ac9d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=gregkh@suse.de \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).