From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: weiping zhang <zhangweiping@didichuxing.com>
Cc: cohuck@redhat.com, virtualization@lists.linux-foundation.org,
mst@redhat.com
Subject: Re: [PATCH v5 4/4] virtio_remoteproc: correct put_device virtio_device.dev
Date: Tue, 2 Jan 2018 09:34:00 -0800 [thread overview]
Message-ID: <20180102173400.GX17344@builder> (raw)
In-Reply-To: <742b7e56647f9a1c9fbf0bbc0dc5b93742382371.1513825904.git.zhangweiping@didichuxing.com>
On Thu 21 Dec 04:40 PST 2017, weiping zhang wrote:
> rproc_virtio_dev_release will be called iff virtio_device.dev's
> reference count drops to 0. Here we just put vdev.dev, and then
> rproc->dev's cleanup will be done in rproc_virtio_dev_release.
>
> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
Thanks weiping and Cornelia, applied.
Regards,
Bjorn
> ---
> drivers/remoteproc/remoteproc_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
> index 2946348..b0633fd 100644
> --- a/drivers/remoteproc/remoteproc_virtio.c
> +++ b/drivers/remoteproc/remoteproc_virtio.c
> @@ -327,7 +327,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
>
> ret = register_virtio_device(vdev);
> if (ret) {
> - put_device(&rproc->dev);
> + put_device(&vdev->dev);
> dev_err(dev, "failed to register vdev: %d\n", ret);
> goto out;
> }
> --
> 2.9.4
>
prev parent reply other threads:[~2018-01-02 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 12:40 [PATCH v5 4/4] virtio_remoteproc: correct put_device virtio_device.dev weiping zhang
2017-12-22 13:40 ` Cornelia Huck
2018-01-02 17:34 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102173400.GX17344@builder \
--to=bjorn.andersson@linaro.org \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).