From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Cc: "Duyck, Alexander H" <alexander.h.duyck@intel.com>,
virtio-dev@lists.oasis-open.org, Jakub Kicinski <kubakici@wp.pl>,
Netdev <netdev@vger.kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
virtualization@lists.linux-foundation.org,
achiad shochat <achiad.mellanox@gmail.com>,
Achiad Shochat <achiad@mellanox.com>,
David Miller <davem@davemloft.net>
Subject: Re: [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit
Date: Tue, 23 Jan 2018 02:05:48 +0200 [thread overview]
Message-ID: <20180123020332-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <7edf772b-627c-6121-3332-479caed524da@intel.com>
On Mon, Jan 22, 2018 at 03:27:40PM -0800, Samudrala, Sridhar wrote:
> > > You could probably
> > > even handle the Tx queue selection via a simple eBPF program and map
> > > since the input for whatever is used to select Tx should be pretty
> > > simple, destination MAC, source NUMA node, etc, and the data-set
> > > shouldn't be too large.
> > That sounds interesting. A separate device might make this kind of setup
> > a bit easier. Sridhar, did you look into creating a separate device for
> > the virtual bond device at all? It does not have to be in a separate
> > module, that kind of refactoring can come later, but once we commit to
> > using the same single device as virtio, we can't change that.
>
> No. I haven't looked into creating a separate device. If we are going to
> create a new
> device, i guess it has to be of a new device type with its own driver.
Well not necessarily - just a separate netdev ops.
Kind of like e.g. vlans share a driver with the main driver.
> As we are using virtio_net to control and manage the VF data path, it is not
> clear to me
> what is the advantage of creating a new device rather than extending
> virtio_net to manage
> the VF datapath via transparent bond mechanism.
>
> Thanks
> Sridhar
So that XDP redirect actions can differentiate between virtio, PT
device and the bond. Without it there's no way to redirect
to virtio specifically.
--
MST
next prev parent reply other threads:[~2018-01-23 0:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1515736720-39368-1-git-send-email-sridhar.samudrala@intel.com>
2018-01-12 5:58 ` [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Sridhar Samudrala
2018-01-12 5:58 ` [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-01-12 5:58 ` [RFC PATCH 1/1] qemu: Introduce VIRTIO_NET_F_BACKUP feature bit to virtio_net Sridhar Samudrala
[not found] ` <1515736720-39368-2-git-send-email-sridhar.samudrala@intel.com>
2018-01-17 18:15 ` [virtio-dev] [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Alexander Duyck
[not found] ` <CAKgT0Uc8bRoAsXYSr7k27gf5+vh7rF2Dd_kWNB1d38tpZAeRGg@mail.gmail.com>
2018-01-17 19:02 ` Michael S. Tsirkin
[not found] ` <20180117203757-mutt-send-email-mst@kernel.org>
2018-01-17 19:25 ` Samudrala, Sridhar
[not found] ` <058068e5-febd-92c8-e5a9-faf262b82335@intel.com>
2018-01-17 19:57 ` Michael S. Tsirkin
[not found] ` <20180117213527-mutt-send-email-mst@kernel.org>
2018-01-17 21:49 ` Alexander Duyck
[not found] ` <CAKgT0UeyNvVQc11KXc3updJfa9p7a9NcfRC=gP6=ktkjrSkOag@mail.gmail.com>
2018-01-22 21:31 ` Michael S. Tsirkin
[not found] ` <20180122231713-mutt-send-email-mst@kernel.org>
2018-01-22 23:27 ` Samudrala, Sridhar
[not found] ` <7edf772b-627c-6121-3332-479caed524da@intel.com>
2018-01-23 0:02 ` Stephen Hemminger
2018-01-23 0:05 ` Michael S. Tsirkin [this message]
2018-01-23 0:16 ` Jakub Kicinski
2018-01-23 0:47 ` Michael S. Tsirkin
[not found] ` <20180123023810-mutt-send-email-mst@kernel.org>
2018-01-23 1:13 ` Jakub Kicinski
[not found] ` <20180122171301.3463156b@cakuba.netronome.com>
2018-01-23 1:23 ` Michael S. Tsirkin
[not found] ` <20180123031348-mutt-send-email-mst@kernel.org>
2018-01-23 19:21 ` Jakub Kicinski
2018-01-23 1:34 ` Samudrala, Sridhar
[not found] ` <be3864b4-f108-6a7d-8628-204d4d4ae278@intel.com>
2018-01-23 2:04 ` Michael S. Tsirkin
[not found] ` <20180123035619-mutt-send-email-mst@kernel.org>
2018-01-23 3:36 ` Alexander Duyck
2018-01-23 5:54 ` Samudrala, Sridhar
2018-01-23 23:01 ` Michael S. Tsirkin
[not found] ` <20180122160204.130451f2@xeon-e3>
2018-01-23 1:37 ` Samudrala, Sridhar
[not found] ` <1515736720-39368-3-git-send-email-sridhar.samudrala@intel.com>
2018-01-22 20:27 ` [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available Siwei Liu
[not found] ` <CADGSJ22BsdB-hDb0xebSyWrwDuBJaFACjb26PDoqAd2Ah+tsQg@mail.gmail.com>
2018-01-22 21:05 ` Samudrala, Sridhar
2018-01-22 21:41 ` Michael S. Tsirkin
[not found] ` <20180122233205-mutt-send-email-mst@kernel.org>
2018-01-23 20:24 ` Siwei Liu
[not found] ` <CADGSJ209vrdjnEAweLg84FwN3sf+1W+APmvB=NjFkMNAhsOyrg@mail.gmail.com>
2018-01-23 22:58 ` Michael S. Tsirkin
[not found] ` <20180124004556-mutt-send-email-mst@kernel.org>
2018-01-26 8:14 ` Siwei Liu
[not found] ` <CADGSJ2308J=tb1B1zrPi0bFzqYSoLfJsRZxBg6wT+wuCfRO6vw@mail.gmail.com>
2018-01-26 16:51 ` [virtio-dev] " Samudrala, Sridhar
[not found] ` <731db0a0-85e7-a88e-6e0e-c540086347b5@intel.com>
2018-01-26 21:46 ` Siwei Liu
[not found] ` <CADGSJ205yeyGV2nJ9Cr=FwPypxAHb12jx3WitS6UmWSJ9VP42Q@mail.gmail.com>
2018-01-26 22:14 ` Michael S. Tsirkin
[not found] ` <20180127000831-mutt-send-email-mst@kernel.org>
2018-01-26 22:47 ` Jakub Kicinski
[not found] ` <20180126144704.6e1a9628@cakuba.netronome.com>
2018-01-26 23:30 ` Samudrala, Sridhar
2018-01-27 2:30 ` Jakub Kicinski
2018-01-27 5:33 ` Samudrala, Sridhar
2018-01-27 5:58 ` Jakub Kicinski
2018-01-28 17:35 ` Alexander Duyck
[not found] ` <CAKgT0Ud4e9O-FoY242Kn_yBX7JWtL_i=yW+Y-MXQ9BGEVBEkgA@mail.gmail.com>
2018-01-28 19:18 ` Samudrala, Sridhar
[not found] ` <f6737111-0015-007c-336b-c8c2793ee590@intel.com>
2018-01-28 20:18 ` Alexander Duyck
[not found] ` <CAKgT0UdaKtPe6982TuuGbxhhVgeehwS1aAp=s4sok2vKD6wMJg@mail.gmail.com>
2018-01-28 21:01 ` Samudrala, Sridhar
[not found] ` <b6bf20f8-8881-4d25-db4c-24f93d5e6cba@intel.com>
2018-01-29 0:58 ` Alexander Duyck
2018-01-28 23:02 ` Stephen Hemminger
[not found] ` <20180128150237.35237d84@xeon-e3>
2018-01-29 4:26 ` Alexander Duyck
[not found] ` <CAKgT0UfEHc6T4MbAwFjx4c2TK1hL-_eGDpSiBEY_ryN_4UaPoQ@mail.gmail.com>
2018-01-29 18:24 ` Michael S. Tsirkin
[not found] ` <20180129202113-mutt-send-email-mst@kernel.org>
2018-01-29 20:09 ` Alexander Duyck
2018-01-23 10:33 ` Jason Wang
2018-01-23 16:03 ` Samudrala, Sridhar
[not found] ` <f6d80eca-8f95-861c-6717-7df53af870fe@intel.com>
2018-01-29 3:32 ` Jason Wang
2018-01-26 16:58 ` Michael S. Tsirkin
2018-01-26 18:15 ` Samudrala, Sridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123020332-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=achiad.mellanox@gmail.com \
--cc=achiad@mellanox.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox